Hide post footer when empty

[davwheat]

Changes proposed in this pull request:

This PR changes the post footer to hide itself when it contains no items.

Currently, even if the footer has no items, it still exists and has margin, resulting in unexpected and weird white space at the bottom of posts.

In the screenshots below, notice the non-even spacing on the EventPost and on the whitespace below the post actions on the CommentPost.

I believe we previously had a more "hacky" way of doing this, by setting the footer bottom margin to 0 for Event Posts, but this fix will affect all posts instead of just Event Posts.

Reviewers should focus on:

This shouldn't be breaking (unless extensions are adding content to footers in hacky ways which we should probably discourage anyway).

As long as extensions are using the ItemList to add items to the footer, this class shouldn't end up being added.

Screenshot

Before:

After:

Confirmed

• Frontend changes: tested on a local Flarum installation.
• Backend changes: tests are green (run composer test).

[dsevillamartin]

Why not just not draw the footer in the DOM, instead of hiding it with CSS?

[davwheat]

I thought about that but assumed it'd be more breaking than just hiding the footer in CSS.

If someone was doing weird stuff, they could override the style if needed to force it to show.

[davwheat]

@SychO9 Seems like your suggestion worked fine! Using :empty pseudoclass but rendering null if no items are in the footer (null renders as nothing, whereas '' renders as a text node it seems).

[SychO9]

nice!