Derive component conflict resolve #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Objective - When creating an asset, the `update_asset_storage` function was unnecessarily creating an extraneous `Handle` to the created asset via calling `set`. This has some overhead as the `RefChange::Increment/Decrement` event was being sent. - A similar exteraneous handle is also created in `load_async` when loading dependencies. ## Solution - Have the implementation use `Assets::set_untracked` and `AssetServer::load_untracked` so no intermediate handle is created.
Since `visible_entities_system` already checks `Visiblie::is_visible` for each entity and requires it to be `true`, there's no reason to verify visibility in `PassNode::prepare` which consumes entities produced by the system.
# Objective - Currently only issues automatically have labels assigned to them on creation. - The enables pull requests to have the same functionality and currently only adds the `needs-triage` label to all PRs. ## Solution - Integrate `actions/labeler@v2` into the github workflows to automatically tag PRs. - Add a `label-config.yml` file that specifies how PRs should be labeled.
# Objective - the PR labeler workflow will always add the `needs-traige` label to every pull request event ## Solution - Limit this workflow to only be on the `opened` event
[RENDERED](https://github.com/NiklasEi/bevy/blob/ecs_readme/crates/bevy_ecs/README.md) Since I am trying to learn more about Bevy ECS at the moment, I thought this issue is a perfect fit. This PR adds a readme to the `bevy_ecs` crate containing a minimal running example of stand alone `bevy_ecs`. Unique features like customizable component storage, Resources or change detection are introduced. For each of these features the readme links to an example in a newly created examples directory inside the `bevy_esc` crate. Resolves bevyengine#2008 Co-authored-by: Carter Anderson <mcanders1@gmail.com>
fixes bevyengine#2169 Instead of having custom methods with reduced visibility, implement `From<image::DynamicImage> for Texture` and `TryFrom<Texture> for image::DynamicImage`
1) Sets `LoadState` properly on all failing cases in `AssetServer::load_async` 2) Adds more tests for sad and happy paths of asset loading _Note_: this brings in the `tempfile` crate.
When loading a gltf, if there is an error loading textures, it is completely ignored. This can happen for example when loading a file with `jpg` textures without the `jpeg` Bevy feature enabled. This PR adds `warn` logs for the few cases that can happen when loading a texture. Other possible fix would be to break on first error and returning, making the asset loading failed
…ngine#2318) # Objective - Currently, when calling any of the `AssetServer`'s `load` functions, if the extension does not exist for the given path, the returned handle's load state is always `LoadState::NotLoaded`. - This is due to the `load_async` function early returning without properly creating a `SourceInfo` for the requested asset. - Fixes bevyengine#2261 ## Solution - Add the `SourceInfo` prior to checking for valid extension loaders. And set the `LoadState` to `Failed` if the according loader does not exist.
# Objective - Fixes bevyengine#2299 ## Solution - Ensures that textures are never requested with 0 height/width.
# Objective Prevent future unnecessary mental effort spent figuring out why this trait exists and how to resolve the `TODO`. ## Solution I happened to notice this trait being used when expanding the `#[derive(Reflect)]` macro in my own crate to figure out how it worked, and noticed that there was a `TODO` comment on it because it is only used in the derive macro and thus appeared to be unused. I figured I should document my findings to prevent someone else from finding them out the hard way in the future 😆 Co-authored-by: Waridley <Waridley64@gmail.com>
# Objective Currently, you can't call `is_added` or `is_changed` on a `NonSend` SystemParam, unless the Resource is a Component (implements `Send` and `Sync`). This defeats the purpose of providing change detection for NonSend Resources. While fixing this, I also noticed that `NonSend` does not have a bound at all on its struct. ## Solution Change the bounds of `T` to always be `'static`.
# Objective - The `DetectChanges` trait is used for types that detect change on mutable access (such as `ResMut`, `Mut`, etc...) - `DetectChanges` was not implemented for `NonSendMut` ## Solution - implement `NonSendMut` in terms of `DetectChanges`
# Objective - Currently `AssetServer::get_handle_path` always returns `None` since the inner hash map is never written to. ## Solution - Inside the `load_untracked` function, insert the asset path into the map. This is similar to bevyengine#1290 (thanks @TheRawMeatball)
# Objective - CI jobs are starting to fail due to `clippy::bool-assert-comparison` and `clippy::single_component_path_imports` being triggered. ## Solution - Fix all uses where `asset_eq!(<condition>, <bool>)` could be replace by `assert!` - Move the `#[allow()]` for `single_component_path_imports` to `#![allow()]` at the start of the files.
# Objective bevyengine#2230 allowed the CI to run on every Branch of this Repo. But some Branches should not actually run the CI, which wastes the available capacity of CI runners. ### staging-squash-merge.tmp This Branch is used by Bors when squashing a PR. CI shouldn't need to run here, as the actual verification happens in the staging branch   ### dependabot/** Dependabot creates its branches in this Repo, which causes the CI to run twice on the same commit  ## Solution Exclude those branches from running CI.
# Objective - Make it so that `Time` can be cloned - Makes it so I can clone the entire current `Time` and easily pass it to the user in [Rusty Engine](https://github.com/CleanCut/rusty_engine) instead of [doing this](https://github.com/CleanCut/rusty_engine/blob/8302dc3914d5b14b730e994cca452ce8d252fec2/src/game.rs#L147-L150) ## Solution - Derive the `Clone` trait on `Time`
# Objective - This adds a way to add `SystemSet`s to Apps.
Updates the requirements on [wgpu](https://github.com/gfx-rs/wgpu) to permit the latest version. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/gfx-rs/wgpu/blob/master/CHANGELOG.md">wgpu's changelog</a>.</em></p> <blockquote> <h1>Change Log</h1> <h2>v0.9 (2021-06-18)</h2> <ul> <li>Updated: <ul> <li>naga to <code>v0.5</code>.</li> </ul> </li> <li>Added: <ul> <li><code>Features::VERTEX_WRITABLE_STORAGE</code>.</li> <li><code>Features::CLEAR_COMMANDS</code> which allows you to use <code>cmd_buf.clear_texture</code> and <code>cmd_buf.clear_buffer</code>.</li> </ul> </li> <li>Changed: <ul> <li>Updated default storage buffer/image limit to <code>8</code> from <code>4</code>.</li> </ul> </li> <li>Fixed: <ul> <li><code>Buffer::get_mapped_range</code> can now have a range of zero.</li> <li>Fixed output spirv requiring the "kernal" capability.</li> <li>Fixed segfault due to improper drop order.</li> <li>Fixed incorrect dynamic stencil reference for Replace ops.</li> <li>Fixed tracking of temporary resources.</li> <li>Stopped unconditionally adding cubemap flags when the backend doesn't support cubemaps.</li> </ul> </li> <li>Validation: <ul> <li>Ensure that if resources are viewed from the vertex stage, they are read only unless <code>Features::VERTEX_WRITABLE_STORAGE</code> is true.</li> <li>Ensure storage class (i.e. storage vs uniform) is consistent between the shader and the pipeline layout.</li> <li>Error when a color texture is used as a depth/stencil texture.</li> <li>Check that pipeline output formats are logical</li> <li>Added shader label to log messages if validation fails.</li> </ul> </li> <li>Tracing: <ul> <li>Make renderpasses show up in the trace before they are run.</li> </ul> </li> <li>Docs: <ul> <li>Fix typo in <code>PowerPreference::LowPower</code> description.</li> </ul> </li> <li>Player: <ul> <li>Automatically start and stop RenderDoc captures.</li> </ul> </li> <li>Examples: <ul> <li>Handle winit's unconditional exception.</li> </ul> </li> <li>Internal: <ul> <li>Merged wgpu-rs and wgpu back into a single repository.</li> <li>The tracker was split into two different stateful/stateless trackers to reduce overhead.</li> <li>Added code coverage testing</li> <li>CI can now test on lavapipe</li> <li>Add missing extern "C" in wgpu-core on <code>wgpu_render_pass_execute_bundles</code></li> <li>Fix incorrect function name <code>wgpu_render_pass_bundle_indexed_indirect</code> to <code>wgpu_render_bundle_draw_indexed_indirect</code>.</li> </ul> </li> </ul> <h2>wgpu-types-0.8.1 (2021-06-08)</h2> <ul> <li>fix dynamic stencil reference for Replace ops</li> </ul> <h2>v0.8.1 (2021-05-06)</h2> <ul> <li>fix SPIR-V generation from WGSL, which was broken due to "Kernel" capability</li> <li>validate buffer storage classes</li> </ul> <h2>Unreleased</h2> <ul> <li>Added support for storage texture arrays for Vulkan and Metal.</li> </ul> <h2>v0.8 (2021-04-29)</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/gfx-rs/wgpu/commits">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
# Objective - Update `hexasphere` to 4.0.0, which is now licensed with dual MIT/Apache-2.0.
# Objective - update action labeler ## Solution - Update to major version to not get notification update of every patch. - Replace bevyengine#2338.
…vyengine#2345) # Objective Currently, you can add `Option<Res<T>` or `Option<ResMut<T>` as a SystemParam, if the Resource could potentially not exist, but this functionality doesn't exist for `NonSend` and `NonSendMut` ## Solution Adds implementations to use `Option<NonSend<T>>` and Option<NonSendMut<T>> as SystemParams.
# Objective Fixes bevyengine#2361 ## Solution Uses integer division instead of floating-point which prevents precision errors, I think.
# Objective Re-introduce `AHashExt` and respective `with_capacity()` implementations to give a more ergonomic way to set a `HashMap` / `HashSet` capacity. As a note, this has also been discussed and agreed on issue bevyengine#2115, which this PR addresses (leaving `new()` out of the `AHashExt` trait). Fixes bevyengine#2115. ## Solution PR bevyengine#1235 had removed the `AHashExt` trait and respective `with_capacity()`s implementations, leaving only the less ergonomic `HashMap::with_capacity_and_hasher(size, Default::default())` option available. This re-introduces `AHashExt` and respective `with_capacity()` implementations to give a more ergonomic way to set a `HashMap` / `HashSet` capacity.
This can be your 6 months post-christmas present. # Objective - Make `.system` optional - yeet - It's ugly - Alternative title: `.system` is dead; long live `.system` - **yeet** ## Solution - Use a higher ranked lifetime, and some trait magic. N.B. This PR does not actually remove any `.system`s, except in a couple of examples. Once this is merged we can do that piecemeal across crates, and decide on syntax for labels.
# Objective - Currently the `Commands` and `CommandQueue` have no performance testing. - As `Commands` are quite expensive due to the `Box<dyn Command>` allocated for each command, there should be perf tests for implementations that attempt to improve the performance. ## Solution - Add some benchmarking for `Commands` and `CommandQueue`.
# Objective - Extend work done in bevyengine#2398. - Make `.system()` syntax optional when using system descriptor API. ## Solution - Slight change to `ParallelSystemDescriptorCoercion` signature and implementors. --- I haven't touched exclusive systems, because it looks like the only two other solutions are going back to doubling our system insertion methods, or starting to lean into stageless. The latter will invalidate the former, so I think exclusive systems should remian pariahs until stageless. I can grep & nuke `.system()` thorughout the codebase now, which might take a while, or we can do that in subsequent PR(s).
# Objective
- Allow `ScheduleRunnerPlugin` to be instantiated without curly braces. Other plugins in the library already use the semicolon syntax.
- Currently, you have to do the following:
```rust
App::build()
.add_plugin(bevy::core::CorePlugin)
.add_plugin(bevy::app::ScheduleRunnerPlugin {})
```
- With the proposed change you can do this:
```rust
App::build()
.add_plugin(bevy::core::CorePlugin)
.add_plugin(bevy::app::ScheduleRunnerPlugin)
```
## Solution
- Change the `ScheduleRunnerPlugin` definition to use a semicolon instead of curly braces.
I didn't know about MinimalPlugins for way too long. This should increase visibility for others. # Objective Improve visibility and discover in the docs for Default and Minimal Plugins. ## Solution Links the two Docs pages. Co-authored-by: Mirko Rainer <52899592+mirkoRainer@users.noreply.github.com>
This is an updated version of bevyengine#1434 PR. I've encountered this macro problem while trying to use @woubuc's bevy-event-set crate. Co-authored-by: Piotr Balcer <piotr@balcer.eu>
# Objective Prevent some possible problem Found by IntelliJ IDEA ## Solution Double quoting variable and exit on possible failure of cd command.
…#869 (bevyengine#2598) # Objective - Provides more useful error messages when using unsupported shader features. ## Solution Fixes bevyengine#869 - Provided a error message as follows (adding name, set and binding): ``` Unsupported shader bind type CombinedImageSampler (name noiseVol0, set 0, binding 9) ```
## Objective - Clean up remaining references to the trait `FromResources`, which was replaced in favor of `FromWorld` during the ECS rework. ## Solution - Remove the derive macro for `FromResources` - Change doc references of `FromResources` to `FromWorld` (this is the first item in bevyengine#2576)
# Objective
This:
```rust
use bevy::prelude::*;
fn main() {
App::new()
.add_system(test)
.run();
}
fn test(entities: Query<Entity>) {
let mut combinations = entities.iter_combinations_mut();
while let Some([e1, e2]) = combinations.fetch_next() {
dbg!(e1);
}
}
```
fails with the message "the trait bound `bevy::ecs::query::EntityFetch: std::clone::Clone` is not satisfied".
## Solution
It works after adding the naive clone implementation to EntityFetch. I'm not super familiar with ECS internals, so I'd appreciate input on this.
[**RENDERED**](https://github.com/alice-i-cecile/bevy/blob/better-contributing/CONTRIBUTING.md) Improves bevyengine#910. As discussed in bevyengine#1309, we'll need to synchronize content between this and the Bevy website in some way (and clean up the .github file perhaps?). I think doing it as a root-directory file is nicer for discovery, but that's a conversation I'm interested in having. This document is intended to be helpful to beginners to open source and Bevy, and captures what I've learned about our informal practices and values. Reviewers: I'm particularly interested in: - opinions on the items **What we're trying to build**, where I discuss some of the project's high-level values and goals - more relevant details on the `bevy` subcrates for **Getting oriented** - useful tricks and best practices that I missed - better guidance on how to contribute to the Bevy book from @cart <3
I don't see much of a reason at this point to boost my name over anyone elses. We are all Bevy Contributors.
# Objective Enable using exact World lifetimes during read-only access . This is motivated by the new renderer's need to allow read-only world-only queries to outlive the query itself (but still be constrained by the world lifetime). For example: https://github.com/bevyengine/bevy/blob/115b170d1f11a91146bb6d6e9684dceb8b21f786/pipelined/bevy_pbr2/src/render/mod.rs#L774 ## Solution Split out SystemParam state and world lifetimes and pipe those lifetimes up to read-only Query ops (and add into_inner for Res). According to every safety test I've run so far (except one), this is safe (see the temporary safety test commit). Note that changing the mutable variants to the new lifetimes would allow aliased mutable pointers (try doing that to see how it affects the temporary safety tests). The new state lifetime on SystemParam does make `#[derive(SystemParam)]` more cumbersome (the current impl requires PhantomData if you don't use both lifetimes). We can make this better by detecting whether or not a lifetime is used in the derive and adjusting accordingly, but that should probably be done in its own pr. ## Why is this a draft? The new lifetimes break QuerySet safety in one very specific case (see the query_set system in system_safety_test). We need to solve this before we can use the lifetimes given. This is due to the fact that QuerySet is just a wrapper over Query, which now relies on world lifetimes instead of `&self` lifetimes to prevent aliasing (but in systems, each Query has its own implied lifetime, not a centralized world lifetime). I believe the fix is to rewrite QuerySet to have its own World lifetime (and own the internal reference). This will complicate the impl a bit, but I think it is doable. I'm curious if anyone else has better ideas. Personally, I think these new lifetimes need to happen. We've gotta have a way to directly tie read-only World queries to the World lifetime. The new renderer is the first place this has come up, but I doubt it will be the last. Worst case scenario we can come up with a second `WorldLifetimeQuery<Q, F = ()>` parameter to enable these read-only scenarios, but I'd rather not add another type to the type zoo.
# Objective While implementing a plugin for my rollback networking library, I needed to load/save parts of the world. For this, I made a WorldSnapshot that works quite like the current DynamicScene. Using a TypeRegistry to register component types I want to save/load and then using ReflectComponents methods to add or apply components of the given types. However, I noticed there is no method to remove components from entities through the ReflectComponent. ## Solution I added a `remove_component` field to the `ReflectComponent` struct, as well as a `pub fn remove_component(&self, world: &mut World, entity: Entity)` to call that function in `remove_component`. This follows exactly the same pattern all other methods/fields in this struct look like. This is an example how it could be used (at least how I would use it): https://github.com/gschup/bevy_ggrs/blob/6c003f86f1993bcbb21c180fab2e8ef664b7f7c9/src/world_snapshot.rs#L133
# Objective - We currently depends on ndk 0.2, 0.3, 0.4 - Only 0.2 dependencies comes from Bevy itself ## Solution - Replace bevyengine#1371 - Update Bevy to ndk-glue 0.4 - Also fixes duplicate dependency CI issue
Updates the requirements on [glam](https://github.com/bitshifter/glam-rs) to permit the latest version. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/bitshifter/glam-rs/blob/master/CHANGELOG.md">glam's changelog</a>.</em></p> <blockquote> <h2>[0.17.3] - 2021-07-18</h2> <h3>Fixed</h3> <ul> <li>Fix alignment unit tests on non x86 platforms.</li> </ul> <h2>[0.17.2] - 2021-07-15</h2> <h3>Fixed</h3> <ul> <li>Fix alignment unit tests on i686 and S390x.</li> </ul> <h2>[0.17.1] - 2021-06-29</h2> <h3>Added</h3> <ul> <li>Added <code>serde</code> support for <code>Affine2</code>, <code>DAffine2</code>, <code>Affine3A</code> and <code>DAffine3</code>.</li> </ul> <h2>[0.17.0] - 2021-06-26</h2> <h3>Breaking changes</h3> <ul> <li>The addition of <code>Add</code> and <code>Sub</code> implementations of scalar values for vector types may create ambiguities with existing calls to <code>add</code> and <code>sub</code>.</li> <li>Removed <code>From<Mat3></code> implementation for <code>Mat2</code> and <code>From<DMat3></code> for <code>DMat2</code>. These have been replaced by <code>Mat2::from_mat3()</code> and <code>DMat2::from_mat3()</code>.</li> <li>Removed <code>From<Mat4></code> implementation for <code>Mat3</code> and <code>From<DMat4></code> for <code>DMat3</code>. These have been replaced by <code>Mat3::from_mat4()</code> and <code>DMat3::from_mat4()</code>.</li> <li>Removed deprecated <code>from_slice_unaligned()</code>, <code>write_to_slice_unaligned()</code>, <code>from_rotation_mat4</code> and <code>from_rotation_ypr()</code> methods.</li> </ul> <h3>Added</h3> <ul> <li>Added <code>col_mut()</code> method which returns a mutable reference to a matrix column to all matrix types.</li> <li>Added <code>AddAssign</code>, <code>MulAssign</code> and <code>SubAssign</code> implementations for all matrix types.</li> <li>Added <code>Add</code> and <code>Sub</code> implementations of scalar values for vector types.</li> <li>Added more <code>glam_assert!</code> checks and documented methods where they are used.</li> <li>Added vector projection and rejection methods <code>project_onto()</code>, <code>project_onto_normalized()</code>, <code>reject_from()</code> and <code>reject_from_normalized()</code>.</li> <li>Added <code>Mat2::from_mat3()</code>, <code>DMat2::from_mat3()</code>, <code>Mat3::from_mat4()</code>, <code>DMat3::from_mat4()</code> which create a smaller matrix from a larger one, discarding a final row and column of the input matrix.</li> <li>Added <code>Mat3::from_mat2()</code>, <code>DMat3::from_mat2()</code>, <code>Mat4::from_mat3()</code> and <code>DMat4::from_mat3()</code> which create an affine transform from a smaller linear transform matrix.</li> </ul> <h3>Changed</h3> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/bitshifter/glam-rs/commit/ecf3904b2fb639a979127f457b259f4b83b0340b"><code>ecf3904</code></a> Prepare release 0.17.3</li> <li><a href="https://github.com/bitshifter/glam-rs/commit/95e02bb43eadbc0c56b3931cbbf1f68a5cc5f910"><code>95e02bb</code></a> Merge branch 'master' of github.com:bitshifter/glam-rs</li> <li><a href="https://github.com/bitshifter/glam-rs/commit/c6dc70258345349de5f1051d19ce1f408532ca89"><code>c6dc702</code></a> More alignment test fixes for when SSE2 is not avaialable.</li> <li><a href="https://github.com/bitshifter/glam-rs/commit/87a3b25872f893fc4e8cbab0bbfbb437d1a2c8fb"><code>87a3b25</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/bitshifter/glam-rs/issues/216">#216</a> from bitshifter/prepare-0.17.2</li> <li><a href="https://github.com/bitshifter/glam-rs/commit/269e5140903f9bf5bcaa8073274f4a0113d7e0cd"><code>269e514</code></a> Prepare for 0.17.2 release.</li> <li><a href="https://github.com/bitshifter/glam-rs/commit/1da7d6459c5f9890275c7fc1871e6c33c825b6b9"><code>1da7d64</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/bitshifter/glam-rs/issues/215">#215</a> from bitshifter/issue-213</li> <li><a href="https://github.com/bitshifter/glam-rs/commit/dc60e20925254f4f1239424685c34953409395df"><code>dc60e20</code></a> Fix align asserts on i686 and S390x architectures.</li> <li><a href="https://github.com/bitshifter/glam-rs/commit/bd8b30e9fbcfd5910dc2af251fecccc31670edf7"><code>bd8b30e</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/bitshifter/glam-rs/issues/212">#212</a> from remilauzier/master</li> <li><a href="https://github.com/bitshifter/glam-rs/commit/a4e97c0b5429547718a9ceacfe5957d1d765bd52"><code>a4e97c0</code></a> Update approx to 0.5</li> <li><a href="https://github.com/bitshifter/glam-rs/commit/059f61952533af3fc32274e5b7ea242ce9a771a7"><code>059f619</code></a> Prepare 0.17.1 release (<a href="https://github-redirect.dependabot.com/bitshifter/glam-rs/issues/211">#211</a>)</li> <li>Additional commits viewable in <a href="https://github.com/bitshifter/glam-rs/compare/0.15.1...0.17.3">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
See the individual commits.
# Objective - the plugin guidelines should be up-to-date and easy to read/understand ## Solution * point to "Bevy Assets" instead of old "Awesome Bevy" * restructure sections * same order for sections and checklist * Update examples with newest release/rev
This matches `ahash::RandomState`, which provides both `Debug` and `Clone`. Notably, implementing `Clone` allows the `StableHashMap`/`Set` to also implement `Clone`. # Objective - Allow `bevy_utils::StableHashMap` to be cloned. ## Solution - Derive `Clone` for `bevy_utils::FixedState`. - Also derive `Debug`, since we're touching it anyway, and this aligns `FixedState` with `ahash::RandomState`.
# Objective - Clarify vague meaning of "Ltr" and "Rtl". For someone familiar with Flex Box, this is easy to understand, but being more explicit will help beginners or those unfamiliar, without the need to do research. ## Solution - Change three letter abbreviation to fully descriptive name.
# Objective - Fixes bevyengine#2716 ## Solution - Implements the the IntoSystemDescriptor trait for SystemDescriptor, which simply returns itself
Fixes bevyengine#2720 (comment) Possibly we should omit the extra bit in brackets, not sure if its warranted.
…nternals, world clearing (bevyengine#2673) This upstreams the code changes used by the new renderer to enable cross-app Entity reuse: * Spawning at specific entities * get_or_spawn: spawns an entity if it doesn't already exist and returns an EntityMut * insert_or_spawn_batch: the batched equivalent to `world.get_or_spawn(entity).insert_bundle(bundle)` * Clearing entities and storages * Allocating Entities with "invalid" archetypes. These entities cannot be queried / are treated as "non existent". They serve as "reserved" entities that won't show up when calling `spawn()`. They must be "specifically spawned at" using apis like `get_or_spawn(entity)`. In combination, these changes enable the "render world" to clear entities / storages each frame and reserve all "app world entities". These can then be spawned during the "render extract step". This refactors "spawn" and "insert" code in a way that I think is a massive improvement to legibility and re-usability. It also yields marginal performance wins by reducing some duplicate lookups (less than a percentage point improvement on insertion benchmarks). There is also some potential for future unsafe reduction (by making BatchSpawner and BatchInserter generic). But for now I want to cut down generic usage to a minimum to encourage smaller binaries and faster compiles. This is currently a draft because it needs more tests (although this code has already had some real-world testing on my custom-shaders branch). I also fixed the benchmarks (which currently don't compile!) / added new ones to illustrate batching wins. After these changes, Bevy ECS is basically ready to accommodate the new renderer. I think the biggest missing piece at this point is "sub apps".
# Objective - QueryState is lacking documentation. Fixes bevyengine#2090 ## Solution - Provide documentation that mirrors Query (as suggested in bevyengine#2090) and modify as needed. Co-authored-by: James Leflang <59455417+jleflang@users.noreply.github.com>
# Objective - Fixes bevyengine#2674 - Check that benches build ## Solution - Adds a job that runs `cargo check --benches` Co-authored-by: Carter Anderson <mcanders1@gmail.com>
It seems like this option needs to be off on Windows: bevyengine/bevy-website#131 This change also simplifies the instructions required for the Fast Compiles section of the book: bevyengine/bevy-website#137
…evyengine#2739) # Objective M1 Macs / Apple Silicon / simply aarch64 needs to be specified for it to compile with zld, so users might be surprised to find that they aren't getting the benefits and see the fast compiles they might be seeing on other platforms. ## Solution - Add it? :)
# Objective
- Make it easy to use HexColorError with `thiserror`, i.e. converting it into other error types.
Makes this possible:
```rust
#[derive(Debug, thiserror::Error)]
pub enum LdtkError {
#[error("An error occured while deserializing")]
Json(#[from] serde_json::Error),
#[error("An error occured while parsing a color")]
HexColor(#[from] bevy::render::color::HexColorError),
}
```
## Solution
- Derive thiserror::Error the same way we do elsewhere (see query.rs for instance)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.