Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - update ndk-glue to 0.4 #2684

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - update ndk-glue to 0.4 #2684

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Aug 18, 2021 •
edited
Loading

Objective

  • We currently depends on ndk 0.2, 0.3, 0.4
  • Only 0.2 dependencies comes from Bevy itself

Solution

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Aug 18, 2021
@mockersf mockersf added C-Dependencies A change to the crates that Bevy depends on O-Android Specific to the Android mobile operating system and removed S-Needs-Triage This issue needs to be labelled labels Aug 18, 2021
@mockersf mockersf mentioned this pull request Aug 19, 2021
Closed
@cart
Copy link
Member

cart commented Aug 19, 2021

Looks good to me!

@cart
Copy link
Member

cart commented Aug 19, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 19, 2021
@mockersf
update ndk-glue to 0.4 (#2684)
1a758dd 
# Objective

- We currently depends on ndk 0.2, 0.3, 0.4
- Only 0.2 dependencies comes from Bevy itself

## Solution

- Replace #1371 
- Update Bevy to ndk-glue 0.4
- Also fixes duplicate dependency CI issue
@bors
Copy link
Contributor

bors bot commented Aug 19, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title update ndk-glue to 0.4 [Merged by Bors] - update ndk-glue to 0.4 Aug 19, 2021
@bors bors bot closed this Aug 19, 2021
@mockersf mockersf mentioned this pull request Aug 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-Dependencies A change to the crates that Bevy depends on O-Android Specific to the Android mobile operating system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mockersf @cart