fix: Remove misleading Spanner DEBUG log for query elapsed time (#1954)

Cloud Spanner Java client library actually delay the execution of query until the first call to ResultSet#next(), hence we can not provide an accurate query elapsed time in spring-cloud-gcp. In addition, change SpannerOperations to SpannerTemplate in Spanner sample to align with other samples. Fixes: #1945
GoogleCloudPlatform · Jun 15, 2023 · 51352ad · 51352ad
1 parent 5beb0e6
commit 51352ad
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/...data-spanner/src/main/java/com/google/cloud/spring/data/spanner/core/SpannerTemplate.java b/...data-spanner/src/main/java/com/google/cloud/spring/data/spanner/core/SpannerTemplate.java
@@ -495,9 +495,6 @@ public <T> T performReadOnlyTransaction(
   }
 
   public ResultSet executeQuery(Statement statement, SpannerQueryOptions options) {
-
-    long startTime = LOGGER.isDebugEnabled() ? System.currentTimeMillis() : 0;
-
     ResultSet resultSet = performQuery(statement, options);
     if (LOGGER.isDebugEnabled()) {
       String message;
@@ -507,7 +504,6 @@ public ResultSet executeQuery(Statement statement, SpannerQueryOptions options)
         message = getQueryLogMessageWithOptions(statement, options);
       }
       LOGGER.debug(message);
-      LOGGER.debug("Query elapsed milliseconds: " + (System.currentTimeMillis() - startTime));
     }
     return resultSet;
   }

diff --git a/...ud-gcp-data-spanner-template-sample/src/main/java/com/example/SpannerTemplateExample.java b/...ud-gcp-data-spanner-template-sample/src/main/java/com/example/SpannerTemplateExample.java
@@ -17,7 +17,7 @@
 package com.example;
 
 import com.google.cloud.spanner.KeySet;
-import com.google.cloud.spring.data.spanner.core.SpannerOperations;
+import com.google.cloud.spring.data.spanner.core.SpannerTemplate;
 import com.google.cloud.spring.data.spanner.core.admin.SpannerDatabaseAdminTemplate;
 import com.google.cloud.spring.data.spanner.core.admin.SpannerSchemaUtils;
 import java.util.Arrays;
@@ -38,37 +38,37 @@ public class SpannerTemplateExample {
 
   private static final String TEMPLATE_TRADER_1 = "template_trader1";
 
-  @Autowired private SpannerOperations spannerOperations;
+  @Autowired private SpannerTemplate spannerTemplate;
 
   @Autowired private SpannerSchemaUtils spannerSchemaUtils;
 
   @Autowired private SpannerDatabaseAdminTemplate spannerDatabaseAdminTemplate;
 
   public void runExample() {
     createTablesIfNotExists();
-    this.spannerOperations.delete(Trader.class, KeySet.all());
-    this.spannerOperations.delete(Trade.class, KeySet.all());
+    this.spannerTemplate.delete(Trader.class, KeySet.all());
+    this.spannerTemplate.delete(Trade.class, KeySet.all());
 
     Trader trader = new Trader(TEMPLATE_TRADER_1, "John", "Doe");
 
-    this.spannerOperations.insert(trader);
+    this.spannerTemplate.insert(trader);
 
     Trade t =
         new Trade(
             "1", "BUY", 100.0, 50.0, "STOCK1", TEMPLATE_TRADER_1, Arrays.asList(99.0, 101.00));
 
-    this.spannerOperations.insert(t);
+    this.spannerTemplate.insert(t);
 
     t.setTradeId("2");
     t.setTraderId(TEMPLATE_TRADER_1);
     t.setAction("SELL");
-    this.spannerOperations.insert(t);
+    this.spannerTemplate.insert(t);
 
     t.setTradeId("1");
     t.setTraderId("template_trader2");
-    this.spannerOperations.insert(t);
+    this.spannerTemplate.insert(t);
 
-    List<Trade> tradesByAction = this.spannerOperations.readAll(Trade.class);
+    List<Trade> tradesByAction = this.spannerTemplate.readAll(Trade.class);
     LOGGER.info("All trades created by the example:");
     for (Trade trade : tradesByAction) {
       LOGGER.info(trade);