Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove misleading DEBUG log for query elapsed time. #1954

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

blakeli0
Copy link
Contributor

Cloud Spanner Java client library actually delay the execution of query until the first call to ResultSet#next(), hence we can not provide an accurate query elapsed time in spring-cloud-gcp.
In addition, change SpannerOperations to SpannerTemplate in Spanner sample to align with other samples.

fixes: #1945

Cloud Spanner Java client library actually delay the execution of query until the first call to ResultSet#next(), hence we can not provide an accurate query elapsed time in spring-cloud-gcp.
In addition, change SpannerOperations to SpannerTemplate in Spanner sample to align with other samples.
@blakeli0 blakeli0 requested a review from a team as a code owner June 14, 2023 21:51
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meltsufin meltsufin merged commit 51352ad into main Jun 15, 2023
@meltsufin meltsufin deleted the remove-query-elapsed-log branch June 15, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve usefulness of SpannerTemplate logging
2 participants