Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using image tag with slashes very slow when parsing. #323

Closed
coollog opened this issue May 29, 2018 · 3 comments
Closed

Using image tag with slashes very slow when parsing. #323

coollog opened this issue May 29, 2018 · 3 comments
Assignees
@chanseokoh
Labels
priority :p0 question User inquiries
Milestone
v0.9.8

Comments

@coollog
Copy link
Contributor

coollog commented May 29, 2018 •
edited
Loading

For example, this image reference: gcr.io/qingyangc-sandbox/jibtestimage:askfjl/waegawvw/aweg

Took 3 min to parse.
@coollog coollog changed the title Using image tag with slashes causes infinite loop when parsing. Using image tag with slashes very slow when parsing. May 29, 2018
@coollog coollog mentioned this issue Jun 2, 2018
Closed
@coollog
Copy link
Contributor Author

coollog commented Jun 5, 2018

https://github.com/GoogleContainerTools/jib/tree/fix-imagereference2

@coollog coollog added the question User inquiries label Jul 14, 2018
@coollog coollog mentioned this issue Jul 20, 2018
Closed
@chanseokoh
Copy link
Member

I think the regex string has a bug. I'll look into fix it.

@chanseokoh chanseokoh self-assigned this Jul 20, 2018
@coollog
Copy link
Contributor Author

coollog commented Jul 20, 2018

@chanseokoh I have this PR #357 that's been sitting around for a while - it doesn't solve the issue but it might help write a better regex - feel free to use/not use it/close it in favor of a new solution

@chanseokoh chanseokoh mentioned this issue Jul 20, 2018
Merged
@coollog coollog added this to the v0.9.8 milestone Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chanseokoh chanseokoh

Labels
priority :p0 question User inquiries
Projects
None yet
Milestone
v0.9.8
Development

No branches or pull requests
3 participants
@TadCordle @coollog @chanseokoh