Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extreme long parsing time for long repository values in the <to> field #678

Closed
hubermi opened this issue Jul 20, 2018 · 3 comments
Closed
Milestone

Comments

@hubermi
Copy link

hubermi commented Jul 20, 2018

Description of the issue:

When defining long docker repository names the parsing process takes extremely long, causing the mvn build job (gradle build job should be affected, too as the root cause is in jib-core) to run with 100% CPU.

Expected behavior:
String length should not have a big impact on parsing time.

Additional Information:
The root cause is the class com.google.cloud.tools.jib.image.ImageReference;
If calling the parse(String reference) method with a repository value that has 27 characters, it takes about 10 seconds to complete. With 28 characters (like in the example above) it takes about 20 seconds, with 29 characters about 40 seconds ...

@coollog
Copy link
Contributor

coollog commented Jul 20, 2018

Hi @hubermi , thanks for reporting the issue! This is related to #323. Labeling this with high priority.

@coollog coollog added this to the v0.9.8 milestone Jul 20, 2018
@coollog
Copy link
Contributor

coollog commented Jul 21, 2018

The fix will be available in the next release (version 0.9.8).

@coollog
Copy link
Contributor

coollog commented Aug 1, 2018

@hubermi we've released version 0.9.8 and this issue should be fixed in that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants