Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex bug #680

Merged
merged 3 commits into from
Jul 20, 2018
Merged

Fix regex bug #680

merged 3 commits into from
Jul 20, 2018

Conversation

chanseokoh
Copy link
Member

Fixes #323 #678

The Javadoc says

<p>A separator is either an underscore, a dot, two underscores, or any number of dashes.

So, it did not make sense to allow a zero-length separator, essentially allowing not needing a separator at all.

    ImageReference.parse("gcr.io/qingyangc-sandbox/jibtestimage:askfjl/waegawvw/aweg");

The above took 206.050 secs. Now 0.014s.

TadCordle
TadCordle approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@TadCordle TadCordle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

coollog
coollog approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@coollog coollog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Nice catch!

@coollog coollog mentioned this pull request Jul 20, 2018
Closed
@coollog coollog added this to the v0.9.8 milestone Jul 20, 2018
@chanseokoh chanseokoh merged commit fe8cf8b into master Jul 20, 2018
@chanseokoh chanseokoh deleted the i323-i678-regex-bug branch July 20, 2018 17:46
@coollog
Copy link
Contributor

coollog commented Jul 21, 2018

Oh forgot to mention to add a changelog entry too, like Fixed slow image reference parsing

@chanseokoh chanseokoh mentioned this pull request Jul 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TadCordle TadCordle TadCordle approved these changes

@coollog coollog coollog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.8
Development

Successfully merging this pull request may close these issues.
3 participants
@chanseokoh @coollog @TadCordle