Implement update checks #2214

TadCordle · 2020-01-06T22:11:27Z

Fixes #2193.

A couple changes from the initial design:

Instead of getting/setting the last modified time of a file to check the last update time, the time of the previous update check is stored as contents of the file. It seems Files.setLastModifiedTime() isn't supported on all platforms.
The file pulled from GCS contains JSON instead of just the version string, for extensibility.
The check is daily instead of weekly.

… i2193-update-checks

…nerTools/jib into i2193-update-checks

…93-update-checks

chanseokoh

First pass. I'll go over once more later.

jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/BuildTarMojo.java

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java

...lugins-common/src/test/java/com/google/cloud/tools/jib/plugins/common/UpdateCheckerTest.java

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java

chanseokoh

Looks good to me. Just some minor comments.

jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/BuildDockerTask.java

jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/BuildImageTask.java

jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/BuildTarTask.java

jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/BuildDockerMojo.java

jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/BuildImageMojo.java

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java

...lugins-common/src/test/java/com/google/cloud/tools/jib/plugins/common/UpdateCheckerTest.java

jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/BuildDockerMojo.java

loosebazooka

LGTM, just waiting on @chanseokoh since he looked at some parts I didn't go too deep into.

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java

chanseokoh

Looks good to me. Some minor points that I am fine with either way.

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java

jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MojoCommon.java

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java

...lugins-common/src/test/java/com/google/cloud/tools/jib/plugins/common/UpdateCheckerTest.java

…93-update-checks

chanseokoh

While we're at it, some minor comments.

...lugins-common/src/test/java/com/google/cloud/tools/jib/plugins/common/UpdateCheckerTest.java

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java

jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/TaskCommon.java

...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java

chanseokoh

LGTM?

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java

TadCordle added 6 commits January 3, 2020 15:26

Progress

4128ce9

Add method for retrieving XDG config directory

76fb821

Merge branch 'xdg-config' of github.com:GoogleContainerTools/jib into…

907b8fc

… i2193-update-checks

Progress

88a86b8

Add unit tests

0dbc81f

Travis?

b80d272

TadCordle added the PR: Not Ready label Jan 6, 2020

googlebot added the cla: yes label Jan 6, 2020

TadCordle added 13 commits January 6, 2020 17:46

Update comment

6f93837

Return full path

575b74a

Fix comment

fefc308

Reduce diff

8c75b78

Nevermind

0aed062

Change base image cache directory

ef8ad1e

Share code

7257f98

Fix test

594bf73

Feedback

4fd8727

Merge branch 'i2216-change-cache-location' of github.com:GoogleContai…

f51248e

…nerTools/jib into i2193-update-checks

Fix directory

dfe86e9

Add system property for config directory

c7709af

Merge branch 'master' of github.com:GoogleContainerTools/jib into i21…

3057a56

…93-update-checks

chanseokoh reviewed Jan 9, 2020

View reviewed changes

loosebazooka reviewed Jan 9, 2020

View reviewed changes

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java Outdated Show resolved Hide resolved

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java Outdated Show resolved Hide resolved

Fixes and feedback

14fe3f5

chanseokoh reviewed Jan 13, 2020

View reviewed changes

Comments

55b0f1d

TadCordle marked this pull request as ready for review January 13, 2020 22:16

TadCordle removed the PR: Not Ready label Jan 13, 2020

loosebazooka reviewed Jan 13, 2020

View reviewed changes

jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/BuildDockerMojo.java Outdated Show resolved Hide resolved

Extract 'skip'

bb25ca9

loosebazooka reviewed Jan 16, 2020

View reviewed changes

chanseokoh reviewed Jan 16, 2020

View reviewed changes

Log before deletion

946626a

chanseokoh approved these changes Jan 16, 2020

View reviewed changes

briandealwis reviewed Jan 17, 2020

View reviewed changes

GoogleContainerTools deleted a comment from loosebazooka Jan 17, 2020

Comments

b1fba58

briandealwis reviewed Jan 17, 2020

View reviewed changes

loosebazooka reviewed Jan 17, 2020

View reviewed changes

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java Outdated Show resolved Hide resolved

loosebazooka reviewed Jan 17, 2020

View reviewed changes

...lugins-common/src/test/java/com/google/cloud/tools/jib/plugins/common/UpdateCheckerTest.java Outdated Show resolved Hide resolved

Copyright

c865371

briandealwis reviewed Jan 17, 2020

View reviewed changes

...lugins-common/src/test/java/com/google/cloud/tools/jib/plugins/common/UpdateCheckerTest.java Outdated Show resolved Hide resolved

briandealwis reviewed Jan 17, 2020

View reviewed changes

...lugins-common/src/test/java/com/google/cloud/tools/jib/plugins/common/UpdateCheckerTest.java Show resolved Hide resolved

TadCordle added 4 commits January 17, 2020 11:58

Merge branch 'master' of github.com:GoogleContainerTools/jib into i21…

f6a10f1

…93-update-checks

More tests

f6a0aa5

Stuff

a7b70a8

Javadoc

e8befde

chanseokoh reviewed Jan 17, 2020

View reviewed changes

...lugins-common/src/test/java/com/google/cloud/tools/jib/plugins/common/UpdateCheckerTest.java Outdated Show resolved Hide resolved

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java Show resolved Hide resolved

chanseokoh reviewed Jan 17, 2020

View reviewed changes

jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/TaskCommon.java Outdated Show resolved Hide resolved

TadCordle added 3 commits January 17, 2020 15:26

Json

0c94c76

More code

ae6288c

Fix

d95d34b

loosebazooka reviewed Jan 21, 2020

View reviewed changes

Ignore unknown fields from pulled json

216bda4

chanseokoh reviewed Jan 21, 2020

View reviewed changes

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java Outdated Show resolved Hide resolved

Input stream

05bd091

chanseokoh approved these changes Jan 21, 2020

View reviewed changes

TadCordle merged commit 2085d21 into master Jan 21, 2020

TadCordle deleted the i2193-update-checks branch January 21, 2020 17:41

briandealwis reviewed Jan 22, 2020

View reviewed changes

jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/UpdateChecker.java Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement update checks #2214

Implement update checks #2214

TadCordle commented Jan 6, 2020 •

edited

Loading

chanseokoh left a comment

chanseokoh left a comment

loosebazooka left a comment

chanseokoh left a comment

chanseokoh left a comment

chanseokoh left a comment

Implement update checks #2214

Implement update checks #2214

Conversation

TadCordle commented Jan 6, 2020 • edited Loading

chanseokoh left a comment

Choose a reason for hiding this comment

chanseokoh left a comment

Choose a reason for hiding this comment

loosebazooka left a comment

Choose a reason for hiding this comment

chanseokoh left a comment

Choose a reason for hiding this comment

chanseokoh left a comment

Choose a reason for hiding this comment

chanseokoh left a comment

Choose a reason for hiding this comment

TadCordle commented Jan 6, 2020 •

edited

Loading