Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.13.0 #808

Merged
merged 2 commits into from
Apr 29, 2018
Merged

Release 1.13.0 #808

merged 2 commits into from
Apr 29, 2018

Conversation

dahlbyk
Copy link
Contributor

@dahlbyk dahlbyk commented Apr 16, 2018

Trying to ship 1.13.0 with latest changes, but working through an npm issue.

Per recent Gitter conversation, adding a prepare step to build when installed from GitHub. @chrisortman, can you verify this works as expected if you install GriddleGriddle/Griddle#v1.13.0?

@chrisortman
Copy link

With yarn 1.5.1 it does not, however I think there may be a bug out there related to this behavior being broken. I am going to test with yarn 1.6.0 and NPM and report back.

@chrisortman
Copy link

chrisortman commented Apr 16, 2018

Using 'GriddleReact/Griddle#1.13.0' as the package identifier:

  • yarn 1.5.1 : No
  • yarn 1.6.0 : No
  • npm 5.6.0 : Yes

I think this is the relevant yarn issue yarnpkg/yarn#5235

That yarn issue says that the broken behavior is only triggered with certain formats of package name. I have tested

I then started thinking that maybe yarn would run these scripts when it puts something into its cache, not takes it out, so I did a yarn cache clean and tried installing

After cache clean

An unexpected error occurred: "https://registry.yarnpkg.com/core-js/-/core-js-1.2.7.tgz: EEXIST: file already exists, mkdir '/Users/me/Library/Caches/Yarn/v1/npm-core-js-1.2.7-652294c14651db28fa93bd2d5ff2983a4f08c636/library/fn'".
yarn install  32.91s user 20.18s system 128% cpu 41.457 total

Seems surprising to me the yarn bug has existed for as long as it has

But NPM works so I guess this probably works as good as it is going to for now

@dahlbyk
Copy link
Contributor Author

dahlbyk commented Apr 16, 2018

@chrisortman thanks!

@joellanciaux @ryanlanciaux @1.3.0 has been published to npm and tagged as next. Not sure how you evaluate fitness to bump latest, so I'll leave that to you.

@dahlbyk dahlbyk mentioned this pull request Apr 16, 2018
@dahlbyk dahlbyk merged commit a0df307 into master Apr 29, 2018
@dahlbyk dahlbyk deleted the release-1.13.0 branch April 29, 2018 04:53
@dahlbyk
Copy link
Contributor Author

dahlbyk commented Apr 29, 2018

Well I merged this so #813 could take a dependency on the prepare script, but CodeSandbox doesn't seem to support that yet. Sigh.

Still open to feedback on the script changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants