Fix: Cannot read property 'onSort' of undefined #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This looks good to me! Not sure about storybook through CI -- would be handy almost to be able to run those as cypress tests haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Griddle major version
1.13.0
Changes proposed in this pull request
Reconciles one-line difference between default and local
TableHeadingCellContainer, which left the former without access toevents.Since those files are supposed to match as of #749, it seems reasonable to avoid double maintenance. As with
TableHeadingCellEnhancer, I've tried to avoid a breaking change for folks who are depending onLocalPluginexportingcomponents.TableHeadingCellContainerby re-exporting the default component.Why these changes are made
Fixes #812 (cc @bsalex)
Are there tests?
Storybook no longer breaks. Anyone know if Storybook can be run through CI?