chore(journal): improve posting core with issue fixes #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the fiscal year schema as requested by #279 in preparation for creating the client-side fiscal year module. It also updates the posting journal's core checks to ensure that integration tests continue to behave appropriately. Specifically, here is what changed: 1) `period.period_start` --> `period.start_date` 2) `period.period_stop` --> `period.end_date` 3) `fiscal_year.previous_fiscal_year` --> `fiscal_year.previous_fiscal_year_id`. 4) REMOVED `fiscal_year.transaction_start_number` 5) REMOVED `fiscal_year.transaction_stop_number` 6) REMOVED `fiscal_year.start_year` 7) REMOVED `fiscal_year.start_month` 8) ADDED `fiscal_year.start_date` DATE 9) ADDED `fiscal_year.created_at` 10) ADDED `fiscal_year.updated_at` 11) `fiscal_year.fiscal_year_txt` --> `fiscal_year.label`
This commit implements the initial cash posting journal route by porting journal/voucher.js to the journal/cash.js. It also implements the following optimizations/cleanups: 1) The @Date, @currencyId, @enterpriseId, and @projectid are all performed in a single SQL `SELECT ... INTO` statement for both the cash and voucher posting. This improves readability and performance. 2) `gain_account_id` and `loss_account_id` are implemented as an enterprise setting, as required by #327 and requested in #324. In a future commit, the gain/loss accounts should be removed from the cashboxes. Closes #327.
This commit refactors cashboxes to no longer manage the gain/loss on exchange accounts and implements suggestions found in #324. The cashboxes API has changed slightly and modernized. Next, the client-side services will be analyzed to ensure they will continue to behave properly.
This commit updates and refactors the cashbox client with newer standards, JSDoc syntax, and the new database schema.
This commit removes unused appstate variables from application.js and fixes errors in the client cashboxes client to allow end to end tests to pass.
This commit does a lot of work: 1) Both cashboxes and account use "?detailed=1" query string parameter instead of "?full=1". Tests, services and controllers have been updated to reflect this. 2) The `Accounts.list()` method has been removed. It's replacement is the standards-compliant `Accounts.read()` method, which doesn't attach children to the accounts list. 3) Cashboxes client no longer offers `<select>` elements for gain/loss on exchange accounts. 4) The Cashbox Currency Modal now uses `bh-submit` to manage the loading state. Closes #324.
jniles
force-pushed
the
chore-improve-cashboxes
branch
from
592d15b
to
9b5042e
Compare
|
@sfount, can I get an amen? |
| data.type = 'primary'; | ||
| } | ||
| // converts is_auxiliary into radio buttons | ||
| data.type = (data.is_auxiliary) ? 'auxiliary' : 'primary'; |
There was a problem hiding this comment.
I would recommend investigating ng-true-value and ng-false-value for driving these radio button states.
I know this module will have to be re-factored to use ui-router very soon so this can be included in that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the posting experience by introducing fixes requested in various issues. Here is what has changed:
Fiscal Year
The fiscal year schema has been updated as requested by #279 in preparation for creating the client-side fiscal year module. It also updates the posting journal's core checks to ensure that integration tests continue to behave appropriately.
Specifically, here is what changed:
period.period_start-->period.start_dateperiod.period_stop-->period.end_datefiscal_year.previous_fiscal_year-->fiscal_year.previous_fiscal_year_id.fiscal_year.transaction_start_numberfiscal_year.transaction_stop_numberfiscal_year.start_yearfiscal_year.start_monthfiscal_year.start_dateDATEfiscal_year.created_atfiscal_year.updated_atfiscal_year.fiscal_year_txt-->fiscal_year.labelJournal Vouchers and Journal Core
SELECT ... INTOstatement for both the cash and voucher posting. This improves readability and performance.gain_account_idandloss_account_idare implemented as an enterprise setting, as required by Move the gain/loss on rounding accounts to theenterpriseentity #327 and requested in Proposal: refactor cashboxes #324.Cashboxes
virementtotransfer.Accounts
list()andread()in theAccountService, of which I removedlist()as being non-standard./accountsAPI also usesdetailedinstead offullin the query string, asdetailedis used in more other APIs.This PR should pass all end-to-end tests that pass in master. Note that there is still a bug with #338.
Hi! Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist
that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process
and help build a stronger application. Thanks!