Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(journal): improve posting core with issue fixes #339

Merged
merged 6 commits into from
Apr 21, 2016
Merged

chore(journal): improve posting core with issue fixes #339

merged 6 commits into from
Apr 21, 2016

Commits on Apr 20, 2016

  1. chore: update fiscal year schema 

    This commit updates the fiscal year schema as requested by #279 in
preparation for creating the client-side fiscal year module.  It also
updates the posting journal's core checks to ensure that integration
tests continue to behave appropriately.

Specifically, here is what changed:
 1) `period.period_start` --> `period.start_date`
 2) `period.period_stop` --> `period.end_date`
 3) `fiscal_year.previous_fiscal_year` -->
 `fiscal_year.previous_fiscal_year_id`.
 4) REMOVED `fiscal_year.transaction_start_number`
 5) REMOVED `fiscal_year.transaction_stop_number`
 6) REMOVED `fiscal_year.start_year`
 7) REMOVED `fiscal_year.start_month`
 8) ADDED `fiscal_year.start_date` DATE
 9) ADDED `fiscal_year.created_at`
 10) ADDED `fiscal_year.updated_at`
 11) `fiscal_year.fiscal_year_txt` --> `fiscal_year.label`
    @jniles
    Jonathan Niles authored and jniles committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    da28b58 View commit details
    Browse the repository at this point in the history

  2. feat: implemented skeletal journal/cash.js 

    This commit implements the initial cash posting journal route by porting
journal/voucher.js to the journal/cash.js.

It also implements the following optimizations/cleanups:
  1) The @Date, @currencyId, @enterpriseId, and @projectid are all
  performed in a single SQL `SELECT ... INTO` statement for both the
  cash and voucher posting.  This improves readability and performance.
  2) `gain_account_id` and `loss_account_id` are implemented as an
  enterprise setting, as required by #327 and requested in #324.

In a future commit, the gain/loss accounts should be removed from the
cashboxes.

Closes #327.
    @jniles
    Jonathan Niles authored and jniles committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    f89255f View commit details
    Browse the repository at this point in the history

  3. WIP(cashboxes): refactoring cash boxes 

    This commit refactors cashboxes to no longer manage the gain/loss on
exchange accounts and implements suggestions found in #324.  The
cashboxes API has changed slightly and modernized.  Next, the
client-side services will be analyzed to ensure they will continue to
behave properly.
    @jniles
    Jonathan Niles authored and jniles committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    eb48ec5 View commit details
    Browse the repository at this point in the history

  4. chore: update cashbox client with new schema 

    This commit updates and refactors the cashbox client with newer
standards, JSDoc syntax, and the new database schema.
    @jniles
    jniles committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    ce3378f View commit details
    Browse the repository at this point in the history

  5. chore: remove unused environmental variables 

    This commit removes unused appstate variables from application.js and
fixes errors in the client cashboxes client to allow end to end tests to
pass.
    @jniles
    jniles committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    929569d View commit details
    Browse the repository at this point in the history

  6. chore: improve cashbox + accounts client 

    This commit does a lot of work:
 1) Both cashboxes and account use "?detailed=1" query string parameter
 instead of "?full=1".  Tests, services and controllers have been
 updated to reflect this.
 2) The `Accounts.list()` method has been removed.  It's replacement is
 the standards-compliant `Accounts.read()` method, which doesn't attach
 children to the accounts list.
 3) Cashboxes client no longer offers `<select>` elements for gain/loss
 on exchange accounts.
 4) The Cashbox Currency Modal now uses `bh-submit` to manage the
 loading state.

Closes #324.
    @jniles
    jniles committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    9b5042e View commit details
    Browse the repository at this point in the history