-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Patient documents #575
Conversation
I've experimented with your branch and this feature is looking great 👍. Component overflow Component style My recommendations are:
Other than these small comments everything else works well for me. These are just recommendations so if there is a reason they are not practical that is not a problem. Otherwise the changes could be included in this pull request to close out the review issue. |
</div> | ||
<div class="col-sm-6" style="height : 250px; overflow: auto;"> | ||
<!-- find document --> | ||
<bh-find-document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads really nicely. The component API looks fantastic. Well done!
@mbayopanda, I've complete a review of the code. It's very good! If you are willing, #575 (comment) could be addressed before this is merged. I agree with @sfount's analysis of the page. The bh-find-document and patient check in panel do not line up. Either in this PR or another, we should make the bh-find-document use a regular panel, instead of a custom CSS box. |
<!-- find document --> | ||
<bh-find-document | ||
patient-uuid="PatientRecordCtrl.patient.uuid" | ||
enable-patient-details="false" | ||
enable-search="false" | ||
enable-option-bar="true" | ||
display="default"> | ||
display="default" | ||
height="250px"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. Hardcoded styles are not a great idea. Is there anyway to make this component take up 100%
height?
This won't block the PR, as it may require CSS changes beyond this component.
b54fa78
to
f176427
Compare
@mbayopanda, LGTM! Well done! |
This PR fix the patient document according the #475 issue.
Closes #475