Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Patient documents #575

Merged
merged 5 commits into from
Jul 15, 2016
Merged

Conversation

mbayopanda
Copy link
Contributor

@mbayopanda mbayopanda commented Jul 13, 2016

This PR fix the patient document according the #475 issue.

  • Fix the avatar image size to fill the box
  • Use of actions buttons in document section for patient record details
  • Fix the downloaded file extension
  • Remove the preview buttons

Closes #475

@sfount
Copy link
Contributor

sfount commented Jul 13, 2016

@mbayopanda

I've experimented with your branch and this feature is looking great 👍.
I have a few comments about how the feature interacts with the overall page.

Component overflow
When there are two or more files attached to an individual patient the component overflows as it should. However the header also scrolls out of view which can lead to having no idea what the content in the middle of the page is.
screenshot 2016-07-13 at 14 21 45
Header overflowing with content

Component style
This component looks great but I think it would be best bring it in-line with the other components on the page - if you disagree then we can adjust the style of the other components. The most important thing is making sure everything looks and works in a reliably similar way.

screenshot 2016-07-13 at 14 26 35
Different component styles

My recommendations are:

  • Content presented using a Panel panel panel-default as used by patient check in.
  • Overflow only the content body to make sure the 'Patient Documents' title is always presented
  • 'No patient documents' alert replaced with text-info, this is how information is presented to users throughout 2.x

Other than these small comments everything else works well for me. These are just recommendations so if there is a reason they are not practical that is not a problem. Otherwise the changes could be included in this pull request to close out the review issue.
@mbayopanda @jniles

</div>
<div class="col-sm-6" style="height : 250px; overflow: auto;">
<!-- find document -->
<bh-find-document
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads really nicely. The component API looks fantastic. Well done!

@jniles
Copy link
Collaborator

jniles commented Jul 14, 2016

@mbayopanda, I've complete a review of the code. It's very good! If you are willing, #575 (comment) could be addressed before this is merged.

I agree with @sfount's analysis of the page. The bh-find-document and patient check in panel do not line up. Either in this PR or another, we should make the bh-find-document use a regular panel, instead of a custom CSS box.

<!-- find document -->
<bh-find-document
patient-uuid="PatientRecordCtrl.patient.uuid"
enable-patient-details="false"
enable-search="false"
enable-option-bar="true"
display="default">
display="default"
height="250px">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. Hardcoded styles are not a great idea. Is there anyway to make this component take up 100% height?

This won't block the PR, as it may require CSS changes beyond this component.

@jniles
Copy link
Collaborator

jniles commented Jul 15, 2016

@mbayopanda, LGTM! Well done!

@jniles jniles merged commit 4b6de52 into IMA-WorldHealth:master Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patient Documents Review
3 participants