-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a "Type Text to Confirm Delete" modal #150
Labels
Comments
jniles
referenced
this issue
in jniles/bhima
Mar 27, 2016
This commit adds in a modal replacement for $window.confirm() for better security. See #150 for reference. The modal is available in the ModalService, which also contains some TODOs for later development. The service exposes a single method, `confirm()` that will resolve with a boolean value, depending on what the user click - "true" for accept and "false" for cancel.
jniles
referenced
this issue
in jniles/bhima
Mar 29, 2016
This commit adds in a modal replacement for $window.confirm() for better security. See #150 for reference. The modal is available in the ModalService, which also contains some TODOs for later development. The service exposes a single method, `confirm()` that will resolve with a boolean value, depending on what the user click - "true" for accept and "false" for cancel.
jniles
referenced
this issue
in jniles/bhima
Mar 29, 2016
This commit adds in a modal replacement for $window.confirm() for better security. See #150 for reference. The modal is available in the ModalService, which also contains some TODOs for later development. The service exposes a single method, `confirm()` that will resolve with a boolean value, depending on what the user click - "true" for accept and "false" for cancel.
jniles
referenced
this issue
in jniles/bhima
Mar 29, 2016
This commit adds in a modal replacement for $window.confirm() for better security. See #150 for reference. The modal is available in the ModalService, which also contains some TODOs for later development. The service exposes a single method, `confirm()` that will resolve with a boolean value, depending on what the user click - "true" for accept and "false" for cancel.
jniles
referenced
this issue
in jniles/bhima
Mar 31, 2016
This commit adds in a modal replacement for $window.confirm() for better security. See #150 for reference. The modal is available in the ModalService, which also contains some TODOs for later development. The service exposes a single method, `confirm()` that will resolve with a boolean value, depending on what the user click - "true" for accept and "false" for cancel.
Closed
@mbayopanda Can you work on this while waiting for a review on #575? Let me know if you need clarification. This modal will be useful when we begin working on the posting journal trial balances and editing records inline. |
@jniles no problemo... i'm working on it... |
mbayopanda
referenced
this issue
in mbayopanda/bhima
Jul 19, 2016
Add warning message when no concordency between pattern and the given value Fix confirm deletion modal Fix error message
jniles
pushed a commit
that referenced
this issue
Jul 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One several pages, we allow uses to delete cashboxes, projects, enterprises, or others. Currently, we create a
$window.confirm()
instance such as the one shown below$window.confirm()
There are a few small problems with this:
$window.confirm()
window.$translate
filter in the controller before display$window.confirm()
windows look very different from the application, potentially leading to confusion.I propose that we create a confirm modal similar to Github's. See below:
Confirm Modal
This could be imported into any module and used similar to how we use
$window.confirm()
, except with promises. For example:The text was updated successfully, but these errors were encountered: