-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy state of externally opened tabs depends on currently selected tab #42
Comments
It makes sense. This is window.QueryInterface(Ci.nsIDOMChromeWindow).browserDOMWindow =
new nsBrowserAccess(); => And there is 3 variants for browser.link.open_newwindow.override.external preference: Ci.nsIBrowserDOMWindow.OPEN_CURRENTWINDOW // 1
Ci.nsIBrowserDOMWindow.OPEN_NEWWINDOW // 2
Ci.nsIBrowserDOMWindow.OPEN_NEWTAB // 3 [Added 2013-08-24] See browser.link.open_external preference for SeaMonkey. But only OPEN_NEWWINDOW and OPEN_NEWTAB may be detected without additional patches for built-in functions. |
Ugh. I recognize that preference and I do have it set to Heck, the only difference between what I've cobbled together and "single window mode" as implemented by various extensions is that I can still force a new window if I want. |
… external application (draft for #42)
…l applications in private tabs (#42)
Looks fixed, but not fully tested. |
Works fine for me, closed. |
If I click a link in Thunderbird or run
firefox something.html
in my terminal, whether or not it's private depends on which tab is currently selected.Given that, with a separate private window, externally-opened tabs always appear on the non-private window, it seems more intuitive that the same behaviour be preserved by Private Tab. (Especially since, if it happens unexpectedly, it could leak information by unintentionally granting an arbitrary site access to the cookie store for the private tabs.)
Edit: Looks like this problem used to occur in Firefox without extensions and Private Tab just broke the fix they made for it: https://bugzilla.mozilla.org/show_bug.cgi?id=829180
The text was updated successfully, but these errors were encountered: