Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patcher: better handle third-party wrappers #46

Closed
Infocatcher opened this issue Apr 26, 2013 · 1 comment
Closed

Patcher: better handle third-party wrappers #46

Infocatcher opened this issue Apr 26, 2013 · 1 comment
Labels
enhancement

Comments

@Infocatcher
Copy link
Owner

See #45 (comment)
We should try to minimize this memory leak.
Infocatcher added a commit that referenced this issue Apr 26, 2013
@Infocatcher
Patcher: always restore wrapped function
91602d7 
(part 1 for #46, enhancement for #45)
Infocatcher added a commit that referenced this issue Apr 26, 2013
@Infocatcher
Patcher: remove overrided toString()/toSource()
d7790e3 
Also "unload" listener, added in #45, seems to be useless
(part 2 for #46)
Infocatcher added a commit that referenced this issue Apr 26, 2013
@Infocatcher
Patcher: move into separate module
8608140 
Benefits: better incapsulation and only this module will be leaked in case of third-party wrappers
(part 3 for #46)
Infocatcher added a commit that referenced this issue Apr 26, 2013
@Infocatcher
Make patcher module universal
4fd87f9 
(part 4 for #46)
Infocatcher added a commit that referenced this issue Apr 27, 2013
@Infocatcher
Patcher: add ability to remove all wrappers (unclude all third-party …
b94cef0 
…wrappers)

And restore "unload" listener (d7790e3), testcase:
* open new window
* add wrapper after Private Tab
* disable Private Tab (unable to remove wrappers)
* close window (unfortunately garbage collector unable to cleanup links to global variables itself)
(part 5 for #46)
Infocatcher added a commit that referenced this issue Apr 28, 2013
@Infocatcher
Patcher: improve compatibility with "use strict" directive
2d05cc0 
(related to #46)
Infocatcher added a commit that referenced this issue May 1, 2013
@Infocatcher
Don't override gBrowser.loadURIWithFlags() in private windows
148ce9f 
(enhancement for #42, also related to #46: NoScript wraps the same function after some delay and don't cleanup link to our wrapper)
@Infocatcher
Copy link
Owner Author

OK, we still have memory leaks, if other extension wraps the same functions and don't remove links to our wrappers on window "unload", but this looks like platform bug and we can't fix it at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Infocatcher