Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to design observers with direct term #861

Merged
merged 6 commits into from
Jul 11, 2023
Merged

add option to design observers with direct term #861

merged 6 commits into from
Jul 11, 2023

Conversation

baggepinnen
Copy link
Member

@baggepinnen baggepinnen commented Jul 10, 2023

This applies to several functions

  • kalman
  • observer_controller
  • place
  • observer_filter (new function in this PR)

This PR also adds the option to let observers output the state estimate rather than the output estimate.

The reference CCS refers to Computer Controlled Systems by Åström and Wittenmark

@baggepinnen baggepinnen requested a review from albheim July 10, 2023 12:26
This applies to several functions
- `kalman`
- `observer_controller`
- `place`
- `observer_filter` (new function in this PR)
@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.047 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.007 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.047 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.007 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #861 (b914815) into master (a047432) will increase coverage by 36.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #861       +/-   ##
===========================================
+ Coverage   56.53%   92.72%   +36.19%     
===========================================
  Files           5        5               
  Lines         329      330        +1     
===========================================
+ Hits          186      306      +120     
+ Misses        143       24      -119     

see 3 files with indirect coverage changes

@baggepinnen baggepinnen merged commit e72a1ca into master Jul 11, 2023
5 checks passed
@baggepinnen baggepinnen deleted the filter branch July 11, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants