Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert pid parameters to :parallel #900

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Convert pid parameters to :parallel #900

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a3b77eb
Convert pid parameters to :parallel
Nov 11, 2023
27a0c18
Throw DomainError when conversion to other form is not possible
Nov 12, 2023
a43c256
Reintroduce convert_pidparams_from_standard
Nov 13, 2023
692b5f9
Re-add broadcasting
Nov 13, 2023
c48eda3
Update lib/ControlSystemsBase/src/pid_design.jl
mzaffalon Nov 13, 2023
9908eaf
Remove broadcasting on convert_pidparams* functions
Nov 13, 2023
5392ea1
merge
Nov 13, 2023
0ac6a75
Update lib/ControlSystemsBase/test/test_pid_design.jl
mzaffalon Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/ControlSystemsBase/src/pid_design.jl 
Co-authored-by: Fredrik Bagge Carlson <baggepinnen@gmail.com>
  • Loading branch information
@mzaffalon @baggepinnen
mzaffalon and baggepinnen committed Nov 13, 2023
commit c48eda3d859548ca1002ee2807ef0b4a731e7813
2 changes: 1 addition & 1 deletion lib/ControlSystemsBase/src/pid_design.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ The `form` can be chosen as one of the following
"""
function convert_pidparams_from_standard(Kp, Ti, Td, form::Symbol)
if form === :standard
return @. (Kp, Ti, Td)
return Kp, Ti, Td
elseif form === :series
Δ = Ti * (Ti - 4 * Td)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines are broken for parameter arrays

Δ < 0 && throw(DomainError("The condition Ti^2 ≥ 4Td*Ti is not satisfied: the PID parameters cannot be converted to series form"))
Expand Down
Loading