-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add FillID method for Service, Route and Consumer #299
Conversation
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 52.73% 52.82% +0.09%
==========================================
Files 68 69 +1
Lines 5012 5077 +65
==========================================
+ Hits 2643 2682 +39
- Misses 1798 1817 +19
- Partials 571 578 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ec12ac2
to
34cefdf
Compare
Looks like the integration tests are blocked by |
@mmorel-35 I hope I addressed all your suggestions, PTAL. |
Would you also need to do it for plugins ? |
I'd rather leave it until it's going to be needed. As I mentioned in the description, we only need this function to work for Service, Route, and Consumer. |
Adds
FillID
methods for Service, Route, and Consumer entities to allow setting deterministic IDs for entities based on their unique properties.For now, it is only implemented for Service, Route and Consumer as that's what's needed on Kubernetes Ingress Controller side to generate stable IDs for analytics in Konnect.
Part of Kong/kubernetes-ingress-controller#3906.