-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests) split out plugin map test #316
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 52.73% 52.73%
=======================================
Files 68 68
Lines 5012 5012
=======================================
Hits 2643 2643
Misses 1798 1798
Partials 571 571
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Separate the plugin arbitrary map default test from the main default test. The new test only checks the arbitrary map field. Changes to the test plugin in upstream Kong break the blanket diff used in the main test, and would require a version split without testing only the relevant field.
a338540
to
189eeea
Compare
I've pushed the change to use require and assert based on correct (subtest's) |
I allow myself to merge this - it unblocks PRs to main. |
Separate the plugin arbitrary map default test from the main default test. The new test only checks the arbitrary map field.
Changes to the test plugin in upstream Kong break the blanket diff used in the main test, and would require a version split without testing only the relevant field.
The issue appeared in https://github.com/Kong/go-kong/actions/runs/4718806033/jobs/8369120871?pr=315
These fields were added upstream for 3.3: Kong/kong@9df893f