chore: update timeout for GitHub workflows (#5733)

Kong · Mar 27, 2024 · cefe680 · cefe680
1 parent e5b218b
commit cefe680
Show file tree

Hide file tree

Showing 29 changed files with 63 additions and 12 deletions.
diff --git a/.github/workflows/_conformance_tests.yaml b/.github/workflows/_conformance_tests.yaml
@@ -11,6 +11,7 @@ on:
 
 jobs:
   dependencies-versions:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     outputs:
       helm-kong: ${{ steps.set-versions.outputs.helm-kong }}
@@ -24,6 +25,7 @@ jobs:
           echo "helm-kong=$(yq -ojson -r '.integration.helm.kong' < .github/test_dependencies.yaml )" >> $GITHUB_OUTPUT
 
   conformance-tests:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     name: ${{ matrix.name }}
     runs-on: ubuntu-latest
     needs: dependencies-versions
@@ -52,12 +54,12 @@ jobs:
           JUNIT_REPORT: "conformance-tests.xml"
           KONG_TEST_EXPRESSION_ROUTES: ${{ matrix.expression_routes }}
           TEST_KONG_KIC_MANAGER_LOG_OUTPUT: ${{ inputs.log-output-file }}
-      
+
       # upload logs when test failed
-      - name: upload KIC logs 
+      - name: upload KIC logs
         if: ${{ failure() && inputs.log-output-file != '' }}
         uses: actions/upload-artifact@v3
-        with: 
+        with:
           name: ${{ matrix.name }}-kic-logs
           path: ${{ inputs.log-output-file }}
           if-no-files-found: ignore

diff --git a/.github/workflows/_docker_build.yaml b/.github/workflows/_docker_build.yaml
@@ -22,6 +22,7 @@ on:
 
 jobs:
   prepare-tags:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     outputs:
       tags: ${{ steps.merge-tags.outputs.tags }}
@@ -70,6 +71,7 @@ jobs:
           echo "tags: ${{ steps.merge-tags.outputs.tags }}"
 
   build:
+    timeout-minutes: ${{ fromJSON(vars.GHA_EXTENDED_TIMEOUT_MINUTES) }}
     runs-on: ubuntu-latest
     needs: prepare-tags
     outputs:

diff --git a/.github/workflows/_e2e_tests.yaml b/.github/workflows/_e2e_tests.yaml
@@ -34,6 +34,7 @@ on:
 
 jobs:
   setup-e2e-tests:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     outputs:
       test_names: ${{ steps.set_test_names.outputs.test_names }}
@@ -69,6 +70,7 @@ jobs:
         run: echo "Test names ${{ steps.set_test_names.outputs.test_names }}"
 
   dependencies-versions:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     outputs:
       kind: ${{ steps.set-versions.outputs.kind }}
@@ -90,6 +92,7 @@ jobs:
           echo "istio=$(yq -r -ojson '.e2e.istio' < .github/test_dependencies.yaml | jq -c)" >> $GITHUB_OUTPUT
 
   kind:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     if: ${{ !cancelled() }}
     needs:
@@ -186,6 +189,7 @@ jobs:
           path: "*-tests.xml"
 
   gke:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     if: ${{ inputs.run-gke }}
     environment: "gcloud"
     runs-on: ubuntu-latest
@@ -215,7 +219,7 @@ jobs:
       - name: check availability of KIC image
         id: check_kic_image
         if: ${{ inputs.kic-image != '' }}
-        # We have to check whether the image passed in inputs is available in the docker hub. 
+        # We have to check whether the image passed in inputs is available in the docker hub.
         # If it's not, we'll fall back to a nightly image later.
         run: (docker manifest inspect ${{ inputs.kic-image }} && echo "kic_image=${{ inputs.kic-image }}" >> $GITHUB_OUTPUT) || true
 
@@ -235,7 +239,7 @@ jobs:
             export kic_image_repo=$(echo ${{ steps.check_kic_image.outputs.kic_image }} | awk '{split($0,a,":"); print a[1]}')
             export kic_image_tag=$(echo ${{ steps.check_kic_image.outputs.kic_image }} | awk '{split($0,a,":"); print a[2]}')
             echo "kic-image=$kic_image_repo" >> $GITHUB_OUTPUT
-            echo "kic-tag=$kic_image_tag" >> $GITHUB_OUTPUT  
+            echo "kic-tag=$kic_image_tag" >> $GITHUB_OUTPUT
           else
             # See the https://github.com/Kong/kubernetes-testing-framework/issues/587 TODO below.
             # If we add local image GKE support, we can get rid of this fallback.
@@ -281,6 +285,7 @@ jobs:
           path: "*-tests.xml"
 
   istio:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     if: ${{ inputs.run-istio }}
     runs-on: ubuntu-latest
     needs: dependencies-versions

diff --git a/.github/workflows/_envtest_tests.yaml b/.github/workflows/_envtest_tests.yaml
@@ -5,6 +5,7 @@ on:
 
 jobs:
   envtest-tests:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     steps:
       - name: checkout repository

diff --git a/.github/workflows/_integration_tests.yaml b/.github/workflows/_integration_tests.yaml
@@ -41,6 +41,7 @@ on:
 
 jobs:
   dependencies-versions:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     outputs:
       kind: ${{ steps.set-versions.outputs.kind }}
@@ -60,6 +61,7 @@ jobs:
           echo "helm-kong=$(yq -ojson -r '.integration.helm.kong' < .github/test_dependencies.yaml )" >> $GITHUB_OUTPUT
 
   integration-tests:
+    timeout-minutes: ${{ fromJSON(vars.GHA_EXTENDED_TIMEOUT_MINUTES) }}
     name: ${{ matrix.name }}
     runs-on: ubuntu-latest
     needs: dependencies-versions
@@ -198,12 +200,12 @@ jobs:
           name: diagnostics-integration-tests-${{ matrix.name }}
           path: /tmp/ktf-diag*
           if-no-files-found: ignore
-      
+
       # upload logs when test failed
-      - name: upload KIC logs 
+      - name: upload KIC logs
         if: ${{ failure() && inputs.log-output-file != '' }}
         uses: actions/upload-artifact@v3
-        with: 
+        with:
           name: integration-tests-kic-logs-${{ matrix.name }}
           path: ${{ inputs.log-output-file }}
           if-no-files-found: ignore

diff --git a/.github/workflows/_kongintegration_tests.yaml b/.github/workflows/_kongintegration_tests.yaml
@@ -5,6 +5,7 @@ on:
 
 jobs:
   kongintegration-tests:
+    timeout-minutes: ${{ fromJSON(vars.GHA_EXTENDED_TIMEOUT_MINUTES) }}
     runs-on: ubuntu-latest
     steps:
       - name: checkout repository

diff --git a/.github/workflows/_linters.yaml b/.github/workflows/_linters.yaml
@@ -5,6 +5,7 @@ on:
 
 jobs:
   lint:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository

diff --git a/.github/workflows/_performance_tests.yaml b/.github/workflows/_performance_tests.yaml
@@ -25,6 +25,7 @@ on:
 
 jobs:
   performance-matrix:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     if: ${{ inputs.res-number-for-perf == '' }}
     runs-on: ubuntu-latest
     strategy:
@@ -115,6 +116,7 @@ jobs:
           if-no-files-found: ignore
 
   performance-target:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     if: ${{ inputs.res-number-for-perf != '' }}
     runs-on: ubuntu-latest
     strategy:

diff --git a/.github/workflows/_test_reports.yaml b/.github/workflows/_test_reports.yaml
@@ -18,6 +18,7 @@ on:
 
 jobs:
   coverage:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     if: ${{ inputs.coverage && !cancelled() }}
     runs-on: ubuntu-latest
     steps:
@@ -41,6 +42,7 @@ jobs:
           verbose: true
 
   buildpulse-report:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     if: ${{ inputs.buildpulse && !cancelled() }}
     runs-on: ubuntu-latest
     steps:

diff --git a/.github/workflows/_unit_tests.yaml b/.github/workflows/_unit_tests.yaml
@@ -5,6 +5,7 @@ on:
 
 jobs:
   unit-tests:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     steps:
       - name: checkout repository

diff --git a/.github/workflows/backport.yaml b/.github/workflows/backport.yaml
@@ -7,6 +7,7 @@ on:
 
 jobs:
   backport:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     name: Backport
     runs-on: ubuntu-latest
     # Only react to merged PRs for security reasons.

diff --git a/.github/workflows/benchmarks.yaml b/.github/workflows/benchmarks.yaml
@@ -10,6 +10,7 @@ permissions:
 
 jobs:
   benchmark:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     name: Run Go benchmarks
     runs-on: ubuntu-latest
     steps:

diff --git a/.github/workflows/check_fixed_issues_references.yaml b/.github/workflows/check_fixed_issues_references.yaml
@@ -7,6 +7,7 @@ on:
 
 jobs:
     check_issues_state:
+      timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
       runs-on: ubuntu-latest
       permissions:
         issues: read
@@ -17,8 +18,9 @@ jobs:
           uses: actions/checkout@v4
         - name: check issues
           run: ./hack/check_fixed_issues_references.sh
-            
+
     notify-on-slack:
+      timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
       runs-on: ubuntu-latest
       needs:
         - check_issues_state

diff --git a/.github/workflows/check_pr_labels.yaml b/.github/workflows/check_pr_labels.yaml
@@ -6,6 +6,7 @@ on:
 
 jobs:
   label:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     steps:
       - uses: pmalek/verify-pr-label-action@v1.4.5

diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml
@@ -21,6 +21,7 @@ on:
 
 jobs:
   up-to-date:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     outputs:
       status: ${{ steps.up-to-date.outputs.status }}
@@ -38,6 +39,7 @@ jobs:
 
   # This job is used to check if the secrets are available. If they are not, we'll skip jobs that require them.
   should-run-with-secrets:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     needs:
     - up-to-date
@@ -55,6 +57,7 @@ jobs:
           fi
 
   tools:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     needs:
     - up-to-date
@@ -126,6 +129,7 @@ jobs:
   # It allows to use this particular job as a required check for PRs.
   # Ref: https://github.com/orgs/community/discussions/26822#discussioncomment-3305794
   passed:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     needs:
       - up-to-date

diff --git a/.github/workflows/cleanup.yaml b/.github/workflows/cleanup.yaml
@@ -7,6 +7,7 @@ on:
 
 jobs:
   gcloud:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     environment: gcloud
     runs-on: ubuntu-latest
     steps:
@@ -24,6 +25,7 @@ jobs:
           GOOGLE_LOCATION: ${{ secrets.GOOGLE_LOCATION }}
 
   konnect:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     steps:
       - name: checkout repository

diff --git a/.github/workflows/codeql.yaml b/.github/workflows/codeql.yaml
@@ -19,6 +19,7 @@ on:
 
 jobs:
   analyze:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     name: analyze
     runs-on: ubuntu-latest
     permissions:

diff --git a/.github/workflows/conformance_tests_report.yaml b/.github/workflows/conformance_tests_report.yaml
@@ -11,6 +11,7 @@ on:
 
 jobs:
   dependencies-versions:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     outputs:
       helm-kong: ${{ steps.set-versions.outputs.helm-kong }}
@@ -28,6 +29,7 @@ jobs:
           echo "helm-kong=$(yq -ojson -r '.integration.helm.kong' < .github/test_dependencies.yaml )" >> $GITHUB_OUTPUT
 
   generate-report:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     needs: dependencies-versions
     steps:

diff --git a/.github/workflows/e2e_nightly.yaml b/.github/workflows/e2e_nightly.yaml
@@ -7,6 +7,7 @@ on:
 
 jobs:
   ensure-nightly-image-was-built:
+    timeout-minutes: ${{ fromJSON(vars.GHA_EXTENDED_TIMEOUT_MINUTES) }}
     runs-on: ubuntu-latest
     steps:
       - name: Check if image built this night exists
@@ -64,6 +65,7 @@ jobs:
 
   notify-on-slack:
     runs-on: ubuntu-latest
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     needs:
       - ensure-nightly-image-was-built
       - e2e-tests

diff --git a/.github/workflows/e2e_targeted.yaml b/.github/workflows/e2e_targeted.yaml
@@ -33,6 +33,7 @@ on:
 
 jobs:
   post-comment-in-pr:
+    timeout-minutes: ${{ fromJSON(vars.GHA_EXTENDED_TIMEOUT_MINUTES) }}
     if: ${{ github.event.inputs.pr-number != '' }}
     runs-on: ubuntu-latest
     env:
@@ -63,6 +64,7 @@ jobs:
   # We need to pick an image to use for the tests. If the input specified one, we use that. Otherwise, we use the one
   # built by the previous job.
   choose-image:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     if: ${{ !cancelled() }}
     needs: build-image

diff --git a/.github/workflows/e2e_trigger_via_label.yaml b/.github/workflows/e2e_trigger_via_label.yaml
@@ -7,8 +7,8 @@ on:
 
 jobs:
   trigger-e2e-tests-targeted:
+    timeout-minutes: ${{ fromJSON(vars.GHA_EXTENDED_TIMEOUT_MINUTES) }}
     if: contains(github.event.*.labels.*.name, 'ci/run-e2e')
-
     runs-on: ubuntu-latest
     env:
       GH_TOKEN: ${{ secrets.K8S_TEAM_BOT_GH_PAT }}

diff --git a/.github/workflows/nightly.yaml b/.github/workflows/nightly.yaml
@@ -7,6 +7,7 @@ on:
 
 jobs:
   build-push-images:
+    timeout-minutes: ${{ fromJSON(vars.GHA_EXTENDED_TIMEOUT_MINUTES) }}
     environment: 'Docker Push'
     runs-on: ubuntu-latest
     steps:

diff --git a/.github/workflows/performance_nightly.yaml b/.github/workflows/performance_nightly.yaml
@@ -7,6 +7,7 @@ on:
 
 jobs:
   ensure-nightly-image-was-built:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     steps:
       - name: Check if image built this night exists
@@ -44,6 +45,7 @@ jobs:
       coverage: false
 
   notify-on-slack:
+    timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}
     runs-on: ubuntu-latest
     needs:
       - ensure-nightly-image-was-built