Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update timeout for GitHub workflows #5733

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Mar 20, 2024

What this PR does / why we need it:

There are 29 PRs from @team-eng-enablement that set the default timeout for our GitHub workflows. This PR aims to do it in one shot.

Company wide vars.GHA_DEFAULT_TIMEOUT = 10 minutes for our use-case repo wide vars.GHA_EXTENDED_TIMEOUT_MINUTES = 30 minutes was defined too

Special notes for your reviewer:

I am wondering if I set it everywhere properly...

@programmer04 programmer04 added area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Mar 20, 2024
@programmer04 programmer04 self-assigned this Mar 20, 2024
@programmer04 programmer04 requested a review from a team as a code owner March 20, 2024 16:48
@programmer04 programmer04 enabled auto-merge (squash) March 20, 2024 16:57
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4%. Comparing base (f57a55c) to head (5d378e9).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5733   +/-   ##
=====================================
  Coverage   73.3%   73.4%           
=====================================
  Files        175     175           
  Lines      18147   18147           
=====================================
+ Hits       13315   13325   +10     
+ Misses      3856    3849    -7     
+ Partials     976     973    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@programmer04 programmer04 added the do not merge let the author merge this, don't merge for them. label Mar 20, 2024
@programmer04
Copy link
Member Author

It seems that ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }} is 10 minutes. It's not enough for our use case, how should we proceed?

@pmalek
Copy link
Member

pmalek commented Mar 20, 2024

It seems that ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }} is 10 minutes. It's not enough for our use case, how should we proceed?

You can ask eng enablement team on #ask-eng-enablement-guild.

@programmer04 programmer04 added the ci/run-e2e Trigger e2e test run from PR label Mar 27, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8450669229

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Mar 27, 2024
@programmer04 programmer04 removed the do not merge let the author merge this, don't merge for them. label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants