Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: programmed condition and conformance #3584

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

mlavacca
Copy link
Member

What this PR does / why we need it:

The GatewayProgrammedCondition and ListenerProgrammedCondition conditions are set on the Gateway. Furthermore, the tests GatewaySecretReferenceGrantAllInNamespace and GatewaySecretReferenceGrantSpecific are fixed. Only GatewaySecretReferenceGrantAllInNamespace has been re-enabled because of an upstream issue that makes the tests fail: kubernetes-sigs/gateway-api#1745.

Which issue this PR fixes:

Part of #3305

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • [ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca requested a review from a team as a code owner February 20, 2023 16:48
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 72.2% // Head: 72.1% // Decreases project coverage by -0.1% ⚠️

Coverage data is based on head (7bddcf4) compared to base (b2dfd59).
Patch coverage: 100.0% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3584     +/-   ##
=======================================
- Coverage   72.2%   72.1%   -0.1%     
=======================================
  Files        130     130             
  Lines      15353   15383     +30     
=======================================
+ Hits       11094   11104     +10     
- Misses      3555    3568     +13     
- Partials     704     711      +7     
Impacted Files Coverage Δ
internal/controllers/gateway/gateway_controller.go 67.9% <100.0%> (+1.1%) ⬆️
internal/controllers/gateway/gateway_utils.go 90.2% <100.0%> (+0.3%) ⬆️
...nternal/controllers/gateway/udproute_controller.go 71.6% <0.0%> (-2.2%) ⬇️
...nternal/controllers/gateway/tlsroute_controller.go 71.4% <0.0%> (-2.1%) ⬇️
...ternal/controllers/gateway/grpcroute_controller.go 69.7% <0.0%> (-2.1%) ⬇️
...ternal/controllers/gateway/httproute_controller.go 69.7% <0.0%> (-1.9%) ⬇️
internal/dataplane/kongstate/service.go 66.0% <0.0%> (-1.3%) ⬇️
internal/dataplane/parser/parser.go 90.7% <0.0%> (-0.9%) ⬇️
internal/dataplane/kongstate/util.go 92.5% <0.0%> (+1.5%) ⬆️
internal/dataplane/kongstate/kongstate.go 73.9% <0.0%> (+4.5%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mlavacca mlavacca merged commit e2abd4a into main Feb 20, 2023
@mlavacca mlavacca deleted the mlavacca/conformance/gateway-secret-reference-grant branch February 20, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants