chore: cleanup err check in conformance tests #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error triggered by the test cleaner makes the test fail only if the error is !NotFound. Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
mlavacca
changed the title
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
shaneutt
pushed a commit
to shaneutt/gateway-api
that referenced
this pull request
Mar 14, 2023
…nd-error chore: cleanup err check in conformance tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The cleanup might be failing because some resources were already previously deleted. For example, the tests
gateway-secret-reference-grant-specificandgateway-secret-reference-grant-all-in-namespacescreate a gateway named in the same way (i.e., the second apply is an update), but the cleaner is called twice. When the cleaner is called the 2nd time on that resource, the cleanup fails because the gateway does not exist anymore, making the test fail.This PR introduces a check on the error triggered by the cleanup function. If
NotFound, the cleanup error can be tolerated.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: