[CI][Win] downloading boost #8474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbucher
added
Windows
External library
Continuous Integration
philbucher
commented
Mar 12, 2021
Co-authored-by: Marc Núñez <marcnc94@gmail.com>
|
can you approve please @marcnunezc ? |
marcnunezc
approved these changes
Mar 12, 2021
marcnunezc
reviewed
Mar 12, 2021
| (New-Object System.Net.WebClient).DownloadFile($url, "$env:TEMP\boost.tar.gz") | ||
| 7z.exe x "$env:TEMP\boost.tar.gz" -o"$env:TEMP\boostArchive" -y | Out-Null | ||
| 7z.exe x "$env:TEMP\boostArchive" -o"$env:TEMP\boost" -y | Out-Null | ||
| Push-Location -Path "$env:TEMP\boost" |
There was a problem hiding this comment.
I think this command is useless here, I think it just prepares the installation (that we are not doing).
We can check if it works in anoter PR to not delay more the blocking
There was a problem hiding this comment.
probably :D
I just copy pasted...
Yes I would merge this PR asap, could you please open a follow up PR with this change (and probably more improvements)?
Thx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
to fix #8472