Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Win] downloading boost #8474

Merged
merged 5 commits into from
Mar 12, 2021
Merged

[CI][Win] downloading boost #8474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58aef01
try to download boost
philbucher Mar 12, 2021
dbb635c
update location of boost
philbucher Mar 12, 2021
11834e4
using boost 1.74
philbucher Mar 12, 2021
e22ddf7
Update .github/workflows/configure.cmd
philbucher Mar 12, 2021
8bdfc40
Update configure.cmd
marcnunezc Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,14 @@ jobs:
path: build
key: ${{ runner.os }}-build-${{ github.sha }}
restore-keys: ${{ runner.os }}-build-

- name: Download boost
run: |
$url = "https://sourceforge.net/projects/boost/files/boost/1.74.0/boost_1_74_0.tar.gz/download"
(New-Object System.Net.WebClient).DownloadFile($url, "$env:TEMP\boost.tar.gz")
7z.exe x "$env:TEMP\boost.tar.gz" -o"$env:TEMP\boostArchive" -y | Out-Null
7z.exe x "$env:TEMP\boostArchive" -o"$env:TEMP\boost" -y | Out-Null
Push-Location -Path "$env:TEMP\boost"
Copy link
Contributor

@marcnunezc marcnunezc Mar 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this command is useless here, I think it just prepares the installation (that we are not doing).

We can check if it works in anoter PR to not delay more the blocking

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably :D
I just copy pasted...

Yes I would merge this PR asap, could you please open a follow up PR with this change (and probably more improvements)?
Thx


- name: Installing dependencies
shell: cmd
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/configure.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ cmake ^
-G"Visual Studio 16 2019" ^
-H"%KRATOS_SOURCE%" ^
-B"%KRATOS_BUILD%\%KRATOS_BUILD_TYPE%" ^
-DBOOST_ROOT="%BOOST_ROOT_1_72_0%" ^
-DBOOST_ROOT="%TEMP%\boost" ^
-DINSTALL_RUNKRATOS=OFF ^
-DCMAKE_CXX_FLAGS="/Od /we4661 /we4804 /WX" ^
-DFORCE_LOCAL_ZLIB_COMPILATION=ON ^
Expand Down