Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a tag with fixed image on each merge #146

Closed
pehala opened this issue Feb 8, 2023 · 0 comments · Fixed by #149
Closed

Generate a tag with fixed image on each merge #146

pehala opened this issue Feb 8, 2023 · 0 comments · Fixed by #149
Assignees
Labels
kind/enhancement New feature or request

Comments

@pehala
Copy link
Contributor

pehala commented Feb 8, 2023

Problem

Currently, only the latest tag is built on each merge, which logically uses the latest tag for all associated images. This, however, complicates things for QE because images can change under QE hands and will change depending on when it was installed (e.g. a new image of Limitador might have dropped and will automatically be used).

Solution

Generate a new tag (e.g. based on a commit sha), and in that tag, pin the images to a specific digest, similar to how Authorino and its related repositories already do that.

Side-effects

  • This will certainly generate a lot of "junk" in quay repositories
    • Can be addressed when it actually becomes a problem with periodic cleaning
  • Hard to propagate changes from Authorino and Limitador to Kuadrant, meaning there would have to be some triggers that would trigger build when Authorino or Limitador changes.
    • Can be done later. For the initial solution, a Kuadrant-only trigger will suffice (e.g. when something in the kuadrant-operator changes, generate a build)
  • It is almost like doing a release (without docs, changelog etc.) on every merge, so creating a pipeline now will help with the release process later
@pehala pehala added kind/enhancement New feature or request target/current labels Feb 8, 2023
@didierofrivia didierofrivia self-assigned this Feb 28, 2023
mikenairn pushed a commit to mikenairn/kuadrant-operator that referenced this issue Mar 23, 2023
…drant#146)

* add authpolicy validation and pass hostname from httproute

* move targetability check

* allow multiple actions in one authpolicy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants