Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule build images with git sha reference #149

Merged
merged 10 commits into from
Mar 28, 2023

Conversation

didierofrivia
Copy link
Collaborator

@didierofrivia didierofrivia commented Mar 2, 2023

This PR introduces a series of changes that makes it possible to:

  1. Build (and push) images and tag them with it's SHA commit reference
  2. Schedules a daily workflow that collects the dependencies (limitador-operator-bundle, authorino-operator-bundle and wasm-shim)latest SHA references and stores it in this repo's action variables
  3. Schedules a weekly build, providing the make bundle target the dependencies stored variables already collected.
  4. It also provides a workflow_dispatch event, so the user can manually trigger the whole bundle build with specific versions

Closes #146

Other PRs that complements this one:

@didierofrivia didierofrivia changed the title [WIP] Schedulle build images with sha [WIP] Schedule build images with sha Mar 2, 2023
@didierofrivia didierofrivia force-pushed the schedulle-build-images-with-sha branch from 0a08ffb to 0a39c68 Compare March 6, 2023 17:38
@didierofrivia didierofrivia force-pushed the schedulle-build-images-with-sha branch 3 times, most recently from 678a533 to a2d427e Compare March 13, 2023 17:12
@didierofrivia didierofrivia changed the title [WIP] Schedule build images with sha Schedule build images with sha Mar 14, 2023
@didierofrivia didierofrivia changed the title Schedule build images with sha Schedule build images with git sha reference Mar 14, 2023
@didierofrivia didierofrivia marked this pull request as ready for review March 14, 2023 11:24
@didierofrivia didierofrivia requested a review from a team as a code owner March 14, 2023 11:24
.github/workflows/build-images.yaml Outdated Show resolved Hide resolved
.github/workflows/build-images.yaml Outdated Show resolved Hide resolved
@eguzki
Copy link
Contributor

eguzki commented Mar 27, 2023

what is the value of the weekly build?

@eguzki
Copy link
Contributor

eguzki commented Mar 27, 2023

If one of the dependencies is updated, the kuadrant operator generates a new bundle to update the dependency?

@eguzki
Copy link
Contributor

eguzki commented Mar 27, 2023

Do we still build operator bundle with references to latest?? would be good to have them as well.

@didierofrivia
Copy link
Collaborator Author

@eguzki thanks for the review! in response to your comments:

what is the value of the weekly build?

The weekly build will satisfy the needs of QE of having a "snapshot" of kuadrant operator with every dependency pointing to their sha tag stored at the time.

If one of the dependencies is updated, the kuadrant operator generates a new bundle to update the dependency?

Current solution doesn't support this behaviour, it relies only on the weekly build with the dependencies version stored in action variables. These vars are updated on a daily job requesting the latest reference (commit sha)

Do we still build operator bundle with references to latest?? would be good to have them as well.

We still add the latest tag when the push event targets the main branch.

Copy link
Contributor

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try this out!

@didierofrivia didierofrivia merged commit 511decd into main Mar 28, 2023
@didierofrivia didierofrivia deleted the schedulle-build-images-with-sha branch March 28, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: To test
Development

Successfully merging this pull request may close these issues.

Generate a tag with fixed image on each merge
3 participants