Allow to choose an Infinispan cache for the limits instead of creating one #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unleashed
approved these changes
Jun 1, 2021
| @@ -31,6 +31,16 @@ variables: | |||
| - Format: integer. | |||
|
|
|||
|
|
|||
| ## INFINISPAN_CACHE_NAME | |||
There was a problem hiding this comment.
The amount of environment variables is starting to get out of hand... :)
Yes, this is intended to be run with its own container image, but perhaps it would be good to look into also accepting a configuration file providing fallback settings for missing envs?
There was a problem hiding this comment.
Yes, we should consider that. There are more config params coming :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes both in the lib and the server to allow users to choose the Infinispan cache that they'd like to use. In the server side there's a new ENV,
INFINISPAN_CACHE_NAMEfor this. In the lib, I added a new builder for theInfinispanStoragestruct that accepts a cache name.