Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to choose an Infinispan cache for the limits instead of creating one #44

Merged
merged 3 commits into from
Jun 1, 2021
Merged

Allow to choose an Infinispan cache for the limits instead of creating one #44

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6d6657
storage/infinispan: allow to select cache
davidor May 31, 2021
d961020
server: allow to select infinispan cache
davidor May 31, 2021
c915455
server/docs/configuration: add INFINISPAN_CACHE_NAME
davidor May 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions limitador-server/docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ variables:
- Format: integer.


## INFINISPAN_CACHE_NAME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The amount of environment variables is starting to get out of hand... :)

Yes, this is intended to be run with its own container image, but perhaps it would be good to look into also accepting a configuration file providing fallback settings for missing envs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should consider that. There are more config params coming :D


- The name of the Infinispan cache that Limitador will use to store limits and
counters. This variable applies only when [INFINISPAN_URL](#infinispan_url) is
set.
- Optional. By default, Limitador creates a cache called "limitador" and
configured as "local".
- Format: string.


## INFINISPAN_URL

- Infinispan URL. Required only when you want to use Infinispan to store the
Expand Down