Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting from chat index page redirects to the chat page. #3306

Closed
CertifiedJoon opened this issue Jun 6, 2023 · 4 comments · Fixed by #3383
Closed

Deleting from chat index page redirects to the chat page. #3306

CertifiedJoon opened this issue Jun 6, 2023 · 4 comments · Fixed by #3383
Assignees
@CertifiedJoon
Labels
bug Something isn't working website

Comments

@CertifiedJoon
Copy link
Contributor

Deleting a chat from /chat page will redirect /chat/{id}
@olliestanley olliestanley added bug Something isn't working website good first issue Good issue for project newcomers labels Jun 6, 2023
@AmanSal1
Copy link

AmanSal1 commented Jun 6, 2023

can i work on this ?

@Maxuvious Maxuvious mentioned this issue Jun 8, 2023
Closed
@andreaskoepf
Copy link
Collaborator

@AmanSal1 Ollie assigned the task to you three days ago. Please confirm that you started working on it.

@AmanSal1 AmanSal1 removed their assignment Jun 9, 2023
@andreaskoepf andreaskoepf removed the good first issue Good issue for project newcomers label Jun 9, 2023
@CertifiedJoon
Copy link
Contributor Author

I will work on this myself. Would that be okay?

@andreaskoepf
Copy link
Collaborator

I will work on this myself. Would that be okay?

Yes sure, thanks a lot.

This was referenced Jun 11, 2023
Closed
Closed
Merged
notmd added a commit that referenced this issue Jun 13, 2023
@CertifiedJoon @notmd
Bug Fix: Delete feature (Fixes three issues) (#3383)
1f0113f 
Fixes: #3267 
Fixes: #3306 
Fixes: #3378 

Regarding: #3267 
Some of the z-indices were manged by zIndex parameter, while other
components where managed by Portals. Somehow the two conflicted and
created a weird mix of zIndices. I have changed popover's portal into
simple zindex parameter and parents, sibligns, and cousins accordingly.

Regarding: #3306 
The redirection to deleted chat happened because one of its parent
elements were a Link component. Previously, upon pressing delete,
stopEvent() was called to temporarily pause redirection, and redirection
would resume after the delete process. I have changed the Link component
into normal button with onClick redirection, maintaining the
stopPropogation behavior.

Regarding: #3378 
The default behavior of AlertDialog would wrap the text. But somehow
using portal on it would restrict text-wrap behavior. The text-wrap
behavior came back after removal of portal while working on #3267 .

deleting from /chat/{id}
<img width="1466" alt="image"
src="https://github.com/LAION-AI/Open-Assistant/assets/61619422/7faa1895-7894-41c3-ab57-5489db942641">

deleting from /chat
<img width="1440" alt="image"
src="https://github.com/LAION-AI/Open-Assistant/assets/61619422/d7b4494f-02f4-4953-bcd3-bf1c25de3b8f">

toast on delete
<img width="368" alt="image"
src="https://github.com/LAION-AI/Open-Assistant/assets/61619422/6ed228f1-64d3-4169-9657-aaff4e97ce06">

---------

Co-authored-by: notmd <notmd1811@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CertifiedJoon CertifiedJoon

Labels
bug Something isn't working website
Projects
Open-Assistant
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug Fix: Delete feature (Fixes three issues) CertifiedJoon/Open-Assistant
4 participants
@olliestanley @andreaskoepf @CertifiedJoon @AmanSal1