Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both options pertaining to chat management are very nonfunctional #3331

Closed
Maxuvious opened this issue Jun 8, 2023 · 3 comments · Fixed by #3375
Closed

Both options pertaining to chat management are very nonfunctional #3331

Maxuvious opened this issue Jun 8, 2023 · 3 comments · Fixed by #3375
Labels
bug Something isn't working inference website

Comments

@Maxuvious
Copy link

Maxuvious commented Jun 8, 2023

Not only are these functions, opt-out of training data and delete the chat completely, hidden behind other elements (not clickable at all) but they don't actually perform the functionality they depict if you delete the elements in front so that you can get to them - to click them.

image

This is true for both opting out of the chat being used in the training data set and deleting the chat completely (which should also remove it from the data set). Neither do anything at all other than refresh the page.

image

There is another issue #3267 discussing the fact that the delete button is behind other elements and unclickable, but this seems to be a more problematic issue than just what is described there. As well in issue #3306 where we see that this is not only relevant to the chat page itself, but also from the chat index page we see the same issues -- that is minus the buttons being unclickable. I would love to see updates on what is in mind to fix this or remove the functionality because it is not feasible, etc.

image

Small sub-note here: The text "Confirm opting of training data" is not clear as to what logical direction "opting" refers to. This could be opting in or opting out and since there is no notification anywhere showing 'this chat is currently opted into the data set' or 'this chat is opted out of the data set' for instance, we have no idea as to what state this option is in as the end user.

@NoMansPC
Copy link

NoMansPC commented Jun 8, 2023

Opt out of training data definitely doesn't seem to do anything.

@andreaskoepf andreaskoepf added bug Something isn't working website inference labels Jun 9, 2023
@andreaskoepf
Copy link
Collaborator

andreaskoepf commented Jun 9, 2023

(This issue re-states two problems which are already in progress and documented in separate issues #3267 #3306.)

Not yet addressed are the following two open points:

  1. Ensure that the menu entries "Opt out of training data" and "Delete" of the chat list drop down actually reach the inference server. This seems to work already on the chat-overview page (before opening a conversation). But the layout of the confirmation popup shown on the chat overview page is also broken.

image

  1. Change the title "Confirm opting of training data" to "Confirm opting out".

@AbdBarho
Copy link
Collaborator

Opt out of training data definitely doesn't seem to do anything.

it does a put request to our database, that is all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working inference website
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants