Remove Alethio #351
Merged
Remove Alethio #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
force-pushed
the
feature/migrate-to-etherscan
branch
2 times, most recently
from
026abd2
to
f1e28df
Compare
rickycodes
force-pushed
the
feature/migrate-to-etherscan
branch
from
f1e28df
to
ca13b39
Compare
3 tasks
rickycodes
force-pushed
the
feature/migrate-to-etherscan
branch
from
048e8fe
to
ec173c7
Compare
rickycodes
force-pushed
the
feature/migrate-to-etherscan
branch
2 times, most recently
from
0b2b3fb
to
5e34e57
Compare
rickycodes
force-pushed
the
feature/migrate-to-etherscan
branch
from
45d0c59
to
39d50f9
Compare
Gudahtt
reviewed
Feb 18, 2021
Gudahtt
reviewed
Feb 18, 2021
Gudahtt
reviewed
Feb 18, 2021
| @@ -79,74 +79,75 @@ export function getBuyURL(networkCode = '1', address?: string, amount = 5) { | |||
| * @param fromBlock? - Block from which transactions are needed | |||
| * @returns - URL to fetch the transactions from | |||
| */ | |||
| export function getEtherscanApiUrl(networkType: string, address: string, fromBlock?: string): string { | |||
| export function getEtherscanApiUrl( | |||
| networkType: string, | |||
There was a problem hiding this comment.
This is a pre-existing issue, but the network controller actually exports a type that could be used here to improve the typing: NetworkType.
Which has brought to my attention that this would break completely for the network types "localhost" and "rpc" 🤔. Also a pre-existing issue, but... that seems less than ideal.
…ba into feature/migrate-to-etherscan * 'feature/migrate-to-etherscan' of github.com:MetaMask/gaba: Update `sinon` and `@types/sinon` to latest versions (#352) Fix `tsconfig.json` indentation (#355) Replace `fetch-mock` with `nock` (#340) Update `ethereumjs-wallet` from v0.6.5 to v1.0.1 (#347) Add `babel-runtime` dependency required by `ethjs-query` (#341) Update `@metamask/eslint-config` from v3 to v4.1.0 (#344) Add `docs` to list of ignored eslint patterns (#345) Update `uuid` from `v3.3.3` to `v8.3.2` (#346) Update approval controller test import (#339) Add Dependabot config (#343) Update `typedoc` (#342) Remove unused test module (#338) Replace `await-semaphore` with `async-mutex` (#334) Update `eth-json-rpc-filters` in lockfile (#336)
Gudahtt
approved these changes
Feb 18, 2021
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Remove Alethio * Get tests passing * Add util tests * Add some more ignores to get 100 * Update mock to use _not_ alethio * update tests * Fix mocks * Fix lint nit * Remove expect Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Remove Alethio * Get tests passing * Add util tests * Add some more ignores to get 100 * Update mock to use _not_ alethio * update tests * Fix mocks * Fix lint nit * Remove expect Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
alethioApiKeyand all Alethio related code. Instead we now use anetherscanApiKeyand get ERC20 token data from there.