Fix publishing configuration, closes #858 #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
changed the title
rickycodes
force-pushed
the
fix-publishing-config
branch
from
467555d
to
c105f8c
Compare
rickycodes
commented
Jun 30, 2022
mcmire
previously approved these changes
Jul 7, 2022
rickycodes
force-pushed
the
fix-publishing-config
branch
2 times, most recently
from
f230a62
to
6ba32a7
Compare
mcmire
reviewed
Jul 8, 2022
rickycodes
force-pushed
the
fix-publishing-config
branch
from
6ba32a7
to
c1946ca
Compare
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
rickycodes
force-pushed
the
fix-publishing-config
branch
from
a0e9952
to
0d56874
Compare
|
I've tested this all out in my fork and it's correctly skipping for regular pushes:
And releasing when appropriate (after a release PR is merged to
|
rickycodes
force-pushed
the
fix-publishing-config
branch
from
47d5cd8
to
10c4c3e
Compare
mcmire
approved these changes
Jul 11, 2022
Merged
This was referenced Jul 29, 2022
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces some changes to our publishing configuration such that we release from
maininstead ofrelease/*branchesI'm opening this as a WIP Draft PR because this relies on: MetaMask/action-publish-release#46 and a release of it.(that's been addressed now and this is fully ready)
I've created a script for
prepackthat can be skipped in CI viaSKIP_PREPACKenvironment variable. this is because we don't want a new build in CI prior to publish, we just want to pick up the cache from the previous build.I still needed to cacheI'm also not happy about the early exit code I've added here. Ideally, I'd like to see if the version has incremented in the filter and then skip if it hasn't, but I don't believe that's possiblenode_modulesbecause yarn now complains about the state file and it'll halt you from running any yarn scripts if that's not in order (even if we're not using those files for the actual deployment).FIXED:
Issue
Resolves #858