Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use MetaMask/action-check-version@v1.0 #882

Closed
wants to merge 1 commit into from
Closed

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented Jul 29, 2022

When we updated the configuration to cut releases from main in #863 I added a script that checks to ensure the version has been incremented before continuing with the release. I've now gone ahead and authored a separate GitHub action (MetaMask/action-check-version) to accomplish this so we no longer need to have this script littered across repositories.

I've tested this out in my fork and you can view the action run here:
https://github.com/rickycodes/controllers/runs/7580492528?check_suite_focus=true

@rickycodes rickycodes marked this pull request as ready for review July 29, 2022 15:03
@rickycodes rickycodes requested a review from a team as a code owner July 29, 2022 15:03
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add a README for the action repo so we know what it does and how to use it (feel free to copy from other action repos). Aside from that this looks good!

@rickycodes
Copy link
Member Author

closing in favour of #883

@rickycodes rickycodes closed this Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants