Skip to content

Commit

Permalink
Improve regular expression error messages (#5871)
Browse files Browse the repository at this point in the history 
* Add index to RegexAST, change some error messages

Signed-off-by: Anthony Chang <antchang@nvidia.com>

* Require error messages to contain index, and record indices when parsing regex

Signed-off-by: Anthony Chang <antchang@nvidia.com>

* Edit some messages, finish adding position to all errors

Signed-off-by: Anthony Chang <antchang@nvidia.com>

* Add auxillary constructor to RegexAST implementations

Signed-off-by: Anthony Chang <antchang@nvidia.com>

* cleanup

Signed-off-by: Anthony Chang <antchang@nvidia.com>

* Provide more accurate index for empty sequence error

Signed-off-by: Anthony Chang <antchang@nvidia.com>

* Capataize error messages, fix typos, edit tests

Signed-off-by: Anthony Chang <antchang@nvidia.com>
  • Loading branch information
@anthony-chang
anthony-chang authored Jul 7, 2022
1 parent b16f295 commit 0c613e2
Show file tree
Hide file tree
Showing 4 changed files with 244 additions and 104 deletions.
Loading

0 comments on commit 0c613e2

Please sign in to comment.