Improve regular expression error messages #5871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Chang <antchang@nvidia.com>
…ing regex Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
sameerz
added
the
task
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jun 21, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
…prove-regex-error-messages
Signed-off-by: Anthony Chang <antchang@nvidia.com>
anthony-chang
changed the title
…prove-regex-error-messages Signed-off-by: Anthony Chang <antchang@nvidia.com>
|
build |
NVnavkumar
approved these changes
Jul 7, 2022
|
|
||
| case (RegexGroup(capture, term), SimpleQuantifier(ch)) | ||
| if "+*".contains(ch) && !isSupportedRepetitionBase(term) => | ||
| if "+*".contains(ch) && !(isSupportedRepetitionBase(term)._1) => |
There was a problem hiding this comment.
Would recommend converting this to a pattern matching construct to avoid _1, _2 references and the use Option.get().
There was a problem hiding this comment.
I'll do this in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4537
This PR improves the error messages when throwing
RegexUnsupportedExceptionsby attempting to isolate what exactly in the pattern is not supported. I also added apositionfield toRegexASTand recorded the index of each node in the AST within the regular expression pattern in theparsestage, so that this can be printed in errors thrown in therewritestage. AllRegexUnsupportedExceptionsmust specify the index now.There should be no changes to functionality.