Skip to content

Commit

Permalink
Fix nightly scripts to deploy w/ classifier correctly [skip ci] (#5287)
Browse files Browse the repository at this point in the history
* fix nightly script deployment w/ classifier

Signed-off-by: Peixin Li <pxli@nyu.edu>

* address comments
  • Loading branch information
pxLi authored Apr 20, 2022
1 parent ce93b33 commit a932b82
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion jenkins/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ $DEPLOY_CMD -Durl=$SERVER_URL -DrepositoryId=$SERVER_ID \
$DEPLOY_CMD -Durl=$SERVER_URL -DrepositoryId=$SERVER_ID \
$SRC_DOC_JARS \
-Dfile=$FPATH.jar -DgroupId=com.nvidia -DartifactId=$ART_ID -Dversion=$ART_VER \
-DpomFile="$POM_FPATH" -Dclassifiers=$CUDA_CLASSIFIER
-Dfiles=$FPATH.jar -Dtypes=jar -Dclassifiers=$CUDA_CLASSIFIER \
-DpomFile="$POM_FPATH"

###### Deploy profiling tool jar(s) ######
TOOL_PL=${TOOL_PL:-"tools"}
Expand Down
6 changes: 3 additions & 3 deletions jenkins/spark-nightly-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ ART_ID=$(mvnEval project.artifactId)
ART_GROUP_ID=$(mvnEval project.groupId)
ART_VER=$(mvnEval project.version)

DIST_FPATH="$DIST_PL/target/$ART_ID-$ART_VER-$CUDA_CLASSIFIER"
DIST_FPATH="$DIST_PL/target/$ART_ID-$ART_VER"
DIST_POM_FPATH="$DIST_PL/target/extra-resources/META-INF/maven/$ART_GROUP_ID/$ART_ID/pom.xml"

DIST_PROFILE_OPT=-Dincluded_buildvers=$(IFS=,; echo "${SPARK_SHIM_VERSIONS[*]}")
Expand All @@ -55,7 +55,7 @@ function distWithReducedPom {

deploy)
mvnCmd="deploy:deploy-file"
mvnExtaFlags="-Durl=${URM_URL}-local -DrepositoryId=snapshots"
mvnExtaFlags="-Durl=${URM_URL}-local -DrepositoryId=snapshots -Dtypes=jar -Dfiles=${DIST_FPATH}.jar -Dclassifiers=$CUDA_CLASSIFIER"
;;

*)
Expand All @@ -71,7 +71,6 @@ function distWithReducedPom {
-DgroupId="${ART_GROUP_ID}" \
-DartifactId="${ART_ID}" \
-Dversion="${ART_VER}" \
-Dclassifiers=$CUDA_CLASSIFIER \
$mvnExtaFlags
}

Expand Down Expand Up @@ -114,6 +113,7 @@ mvn -B clean install -pl '!tools' \
distWithReducedPom "install"

if [[ $SKIP_DEPLOY != 'true' ]]; then
DIST_FPATH="$DIST_FPATH-$CUDA_CLASSIFIER"
distWithReducedPom "deploy"

# this deploy includes 'tools' that is unconditionally built with Spark 3.1.1
Expand Down

0 comments on commit a932b82

Please sign in to comment.