Fix nightly scripts to deploy w/ classifier correctly [skip ci] #5287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peixin Li <pxli@nyu.edu>
pxLi
added
bug
pxLi
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
|
build |
NvTimLiu
reviewed
Apr 20, 2022
|
build |
NvTimLiu
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peixin Li pxli@nyu.edu
Its my fault #5280 to incorrectly update classifier deploy support in the common func of nightly script.
for each spark shim, it unexpectedly includes (install shims dist artifacts w/ classifier) independent libcu*.so instead of using the common one, so the final dist jar results in ~ 4 GB :(
deploy.sh change was trying to fix missing
-filesw/ -Dclassifiers, the real release fix is tracked at #5259This fix has been verified internally