Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] dependency info properties file contains error messages #1031

Closed
jlowe opened this issue Oct 27, 2020 · 2 comments
Closed

[BUG] dependency info properties file contains error messages #1031

jlowe opened this issue Oct 27, 2020 · 2 comments
Assignees
@NvTimLiu
Labels
bug Something isn't working build Related to CI / CD or cleanly building P1 Nice to have for release

Comments

@jlowe
Copy link
Member

jlowe commented Oct 27, 2020

Describe the bug
When building as a normal developer, the various *-info.properties files for each shim contains error messages rather than properties:

$ jar xvf dist/target/rapids-4-spark_2.12-0.3.0-SNAPSHOT.jar spark-3.0.0-info.properties
 inflated: spark-3.0.0-info.properties
$ cat spark-3.0.0-info.properties

/home/jlowe/src/rapids-plugin-4-spark/build/dependency-info.sh: line 30: /jenkins/printJarVersion.sh: No such file or directory
/home/jlowe/src/rapids-plugin-4-spark/build/dependency-info.sh: line 33: /jenkins/printJarVersion.sh: No such file or directory
$

Steps/Code to reproduce bug
Build with mvn verify and execute the commands from the shell session snippet above.

Expected behavior
The properties file should contain valid key=value entries. If the shell script that generates the properties file encounters an error then the build should fail.
@jlowe jlowe added bug Something isn't working ? - Needs Triage Need team to review and classify build Related to CI / CD or cleanly building labels Oct 27, 2020
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Nov 3, 2020
@sameerz sameerz added the P1 Nice to have for release label Nov 3, 2020
@GaryShen2008 GaryShen2008 assigned NvTimLiu and unassigned GaryShen2008 Nov 4, 2020
@NvTimLiu NvTimLiu mentioned this issue Nov 4, 2020
Merged
@revans2
Copy link
Collaborator

revans2 commented Nov 23, 2020

@jlowe @NvTimLiu is this still a problem or has this been fixed?

@jlowe
Copy link
Member Author

jlowe commented Nov 23, 2020

Fixed by #1095

@jlowe jlowe closed this as completed Nov 23, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@revans2
Add retry count and block time metrics (NVIDIA#1031)
113f928 
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NvTimLiu NvTimLiu

Labels
bug Something isn't working build Related to CI / CD or cleanly building P1 Nice to have for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jlowe @revans2 @sameerz @GaryShen2008 @NvTimLiu