-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency info #1095
Dependency info #1095
Conversation
build |
@jlowe @revans2 Mvn will cmp the timestamp among these I buildt spark-rapids from Jenkins maven @jlowe Your case REPO_ID is So I suppose we can just find out the newest jar file in SNAPSHOT folder, as below change shows. Could you please help to review? Thanks! |
build |
6d5b182
to
997c64a
Compare
build |
997c64a
to
588e62b
Compare
The build failed not sure why it didn't update the PR. https://blossom.nvidia.com/sw-gpu-spark-jenkins/job/rapids_premerge-github/391/
|
build |
* Get cudf/spark dependency from the correct .m2 dir 'WORKSPACE' & 'M2DIR' vars are needed for shims to gen the correct cudf/spark dependency info in shims. Below error in 'spark*-info.properties' is due to unset of 'WORKSPACE' & 'M2DIR': build/dependency-info.sh: line 30: /jenkins/printJarVersion.sh: No such file or directory build/dependency-info.sh: line 33: /jenkins/printJarVersion.sh: No such file or directory To fix the error, we set the default values for them in 'build/dependency-info.sh': 'M2DIR=$HOME/.m2/repository' 'WORKSPACE=../..' We also need to explicitly set the correct 'M2DIR' path, in case we change it by '-Dmaven.repo.local=$M2DIR'. Already updated Jenkins scripts to set the correct 'M2DIR'. Signed-off-by: Tim Liu <timl@nvidia.com> * let mvn package fails in case the script 'build/dependency-info.sh' runs failure * Stop mvn build if `build/build-info` fails Signed-off-by: Tim Liu <timl@nvidia.com> * Copyright 2020 Signed-off-by: Tim Liu <timl@nvidia.com>
Signed-off-by: Tim Liu <timl@nvidia.com>
…o it Signed-off-by: Tim Liu <timl@nvidia.com>
Collect snapshot dependency info only in Jenkins build, In dev build, print 'SNAPSHOT' tag without time stamp, e.g.: cudf-0.17-SNAPSHOT.jar
349acb9
to
48f8c93
Compare
rebase PR source to fix merge conflicts |
build |
* Get cudf/spark dependency from the correct .m2 dir (NVIDIA#1062) * Get cudf/spark dependency from the correct .m2 dir 'WORKSPACE' & 'M2DIR' vars are needed for shims to gen the correct cudf/spark dependency info in shims. Below error in 'spark*-info.properties' is due to unset of 'WORKSPACE' & 'M2DIR': build/dependency-info.sh: line 30: /jenkins/printJarVersion.sh: No such file or directory build/dependency-info.sh: line 33: /jenkins/printJarVersion.sh: No such file or directory To fix the error, we set the default values for them in 'build/dependency-info.sh': 'M2DIR=$HOME/.m2/repository' 'WORKSPACE=../..' We also need to explicitly set the correct 'M2DIR' path, in case we change it by '-Dmaven.repo.local=$M2DIR'. Already updated Jenkins scripts to set the correct 'M2DIR'. Signed-off-by: Tim Liu <timl@nvidia.com> * let mvn package fails in case the script 'build/dependency-info.sh' runs failure * Stop mvn build if `build/build-info` fails Signed-off-by: Tim Liu <timl@nvidia.com> * Copyright 2020 Signed-off-by: Tim Liu <timl@nvidia.com> * List the latest SNAPSHOT jar file in local maven repo Signed-off-by: Tim Liu <timl@nvidia.com> * Get the path of 'dependency-info.sh', then set 'WORKSPACE' relative to it Signed-off-by: Tim Liu <timl@nvidia.com> * Only collect dependency info on Jenkins build * Only collect timestamped dependency in Jenkins build Collect snapshot dependency info only in Jenkins build, In dev build, print 'SNAPSHOT' tag without time stamp, e.g.: cudf-0.17-SNAPSHOT.jar * simplifying the dependencylogic
* Get cudf/spark dependency from the correct .m2 dir (NVIDIA#1062) * Get cudf/spark dependency from the correct .m2 dir 'WORKSPACE' & 'M2DIR' vars are needed for shims to gen the correct cudf/spark dependency info in shims. Below error in 'spark*-info.properties' is due to unset of 'WORKSPACE' & 'M2DIR': build/dependency-info.sh: line 30: /jenkins/printJarVersion.sh: No such file or directory build/dependency-info.sh: line 33: /jenkins/printJarVersion.sh: No such file or directory To fix the error, we set the default values for them in 'build/dependency-info.sh': 'M2DIR=$HOME/.m2/repository' 'WORKSPACE=../..' We also need to explicitly set the correct 'M2DIR' path, in case we change it by '-Dmaven.repo.local=$M2DIR'. Already updated Jenkins scripts to set the correct 'M2DIR'. Signed-off-by: Tim Liu <timl@nvidia.com> * let mvn package fails in case the script 'build/dependency-info.sh' runs failure * Stop mvn build if `build/build-info` fails Signed-off-by: Tim Liu <timl@nvidia.com> * Copyright 2020 Signed-off-by: Tim Liu <timl@nvidia.com> * List the latest SNAPSHOT jar file in local maven repo Signed-off-by: Tim Liu <timl@nvidia.com> * Get the path of 'dependency-info.sh', then set 'WORKSPACE' relative to it Signed-off-by: Tim Liu <timl@nvidia.com> * Only collect dependency info on Jenkins build * Only collect timestamped dependency in Jenkins build Collect snapshot dependency info only in Jenkins build, In dev build, print 'SNAPSHOT' tag without time stamp, e.g.: cudf-0.17-SNAPSHOT.jar * simplifying the dependencylogic
* Get cudf/spark dependency from the correct .m2 dir (NVIDIA#1062) * Get cudf/spark dependency from the correct .m2 dir 'WORKSPACE' & 'M2DIR' vars are needed for shims to gen the correct cudf/spark dependency info in shims. Below error in 'spark*-info.properties' is due to unset of 'WORKSPACE' & 'M2DIR': build/dependency-info.sh: line 30: /jenkins/printJarVersion.sh: No such file or directory build/dependency-info.sh: line 33: /jenkins/printJarVersion.sh: No such file or directory To fix the error, we set the default values for them in 'build/dependency-info.sh': 'M2DIR=$HOME/.m2/repository' 'WORKSPACE=../..' We also need to explicitly set the correct 'M2DIR' path, in case we change it by '-Dmaven.repo.local=$M2DIR'. Already updated Jenkins scripts to set the correct 'M2DIR'. Signed-off-by: Tim Liu <timl@nvidia.com> * let mvn package fails in case the script 'build/dependency-info.sh' runs failure * Stop mvn build if `build/build-info` fails Signed-off-by: Tim Liu <timl@nvidia.com> * Copyright 2020 Signed-off-by: Tim Liu <timl@nvidia.com> * List the latest SNAPSHOT jar file in local maven repo Signed-off-by: Tim Liu <timl@nvidia.com> * Get the path of 'dependency-info.sh', then set 'WORKSPACE' relative to it Signed-off-by: Tim Liu <timl@nvidia.com> * Only collect dependency info on Jenkins build * Only collect timestamped dependency in Jenkins build Collect snapshot dependency info only in Jenkins build, In dev build, print 'SNAPSHOT' tag without time stamp, e.g.: cudf-0.17-SNAPSHOT.jar * simplifying the dependencylogic
List the latest SNAPSHOT jar file in local maven repo