Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Unreachable code warnings in GPU window code #1114

Closed
jlowe opened this issue Nov 13, 2020 · 0 comments · Fixed by #1186
Closed

[BUG] Unreachable code warnings in GPU window code #1114

jlowe opened this issue Nov 13, 2020 · 0 comments · Fixed by #1186
Assignees
@firestarman
Labels
bug Something isn't working

Comments

@jlowe
Copy link
Member

jlowe commented Nov 13, 2020

Describe the bug
Building the plugin results in the following unreachable code warnings:

[WARNING] /home/jlowe/src/rapids-plugin-4-spark/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuWindowExpression.scala:196: unreachable code
[WARNING]     case pythonFunc: GpuPythonUDF => pythonFunc
[WARNING]                                      ^
[WARNING] /home/jlowe/src/rapids-plugin-4-spark/sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/python/GpuWindowInPandasExec.scala:265: unreachable code
[WARNING]             case _: GpuPythonUDF => collect("AGGREGATE", frame, e)

Expected behavior
Code should compile without unreachable code warnings
@jlowe jlowe added bug Something isn't working ? - Needs Triage Need team to review and classify labels Nov 13, 2020
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Nov 17, 2020
@jlowe jlowe mentioned this issue Nov 23, 2020
Merged
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 219c0c3605bcea9ba1b27a0b7b0d0b2774c13c2b (NV…
e5ed9bf 
…IDIA#1114)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@firestarman firestarman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compilation and scaladoc warnings jlowe/spark-rapids
3 participants
@jlowe @sameerz @firestarman