Fix compilation and scaladoc warnings #1186
Conversation
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
| @@ -204,8 +204,6 @@ case class GpuWindowExpression(windowFunction: Expression, windowSpec: GpuWindow | |||
| case other => | |||
| throw new IllegalStateException(s"${other.getClass} is not a supported window aggregation") | |||
| } | |||
| // Add support for Pandas (Python) UDF | |||
| case pythonFunc: GpuPythonUDF => pythonFunc | |||
There was a problem hiding this comment.
GpuPythonUDF derives from GpuAggregateWindowFunction which is why the compiler was complaining. This has the same code as that for the GpuAggregateWindowFunction hence it can simply be deleted.
| @@ -262,7 +262,6 @@ trait GpuWindowInPandasExecBase extends UnaryExecNode with GpuExec { | |||
| function match { | |||
| case GpuAggregateExpression(_, _, _, _, _) => collect("AGGREGATE", frame, e) | |||
| case _: GpuAggregateWindowFunction => collect("AGGREGATE", frame, e) | |||
| case _: GpuPythonUDF => collect("AGGREGATE", frame, e) | |||
There was a problem hiding this comment.
Similar situation here. GpuPythonUDF derives from GpuAggregateWindowFunction, hence the unreachable code warning. The implementation here is the same as the case that will be taken in practice, so this can simply be deleted.
There was a problem hiding this comment.
Because this is in a file that is specific to the pandas operations it might be nice to put a comment by line 263 just to say that this includes GpuPythonUDF
|
build |
| @@ -262,7 +262,6 @@ trait GpuWindowInPandasExecBase extends UnaryExecNode with GpuExec { | |||
| function match { | |||
| case GpuAggregateExpression(_, _, _, _, _) => collect("AGGREGATE", frame, e) | |||
| case _: GpuAggregateWindowFunction => collect("AGGREGATE", frame, e) | |||
| case _: GpuPythonUDF => collect("AGGREGATE", frame, e) | |||
There was a problem hiding this comment.
Because this is in a file that is specific to the pandas operations it might be nice to put a comment by line 263 just to say that this includes GpuPythonUDF
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
* Fix compilation and scaladoc warnings Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Add comment about GpuPythonUDF being handled Signed-off-by: Jason Lowe <jlowe@nvidia.com>
* Fix compilation and scaladoc warnings Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Add comment about GpuPythonUDF being handled Signed-off-by: Jason Lowe <jlowe@nvidia.com>
…IDIA#1186) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Fixes #1114, #1115, and #1149.
This cleans up compilation and scaladoc warnings in the build.