Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename variable in ParquetCachedBatchSerializer to splitVectors #1288

Closed
razajafri opened this issue Dec 5, 2020 · 0 comments
Closed

Rename variable in ParquetCachedBatchSerializer to splitVectors #1288

razajafri opened this issue Dec 5, 2020 · 0 comments
Assignees
@razajafri
Labels
task Work required that improves the product but is not user facing

Comments

@razajafri
Copy link
Collaborator

Was this supposed to be named splitVectors?

Originally posted by @jlowe in #1265 (comment)
@razajafri razajafri mentioned this issue Dec 5, 2020
Merged
@razajafri razajafri changed the title Was this supposed to be named splitVectors? Rename variable in ParquetCachedBatchSerializer to splitVectors Dec 5, 2020
@razajafri razajafri self-assigned this Dec 8, 2020
razajafri added a commit to razajafri/spark-rapids that referenced this issue Dec 8, 2020
@razajafri
Code cleanup
f8c9ab9 
Addressed the following issues
NVIDIA#1285
NVIDIA#1286
NVIDIA#1287
NVIDIA#1288
NVIDIA#1289
razajafri added a commit to razajafri/spark-rapids that referenced this issue Dec 8, 2020
@razajafri
Code cleanup
9ba5dff 
Addressed the following issues
NVIDIA#1285
NVIDIA#1286
NVIDIA#1287
NVIDIA#1288
NVIDIA#1289
@razajafri razajafri mentioned this issue Dec 8, 2020
Merged
razajafri added a commit to razajafri/spark-rapids that referenced this issue Dec 8, 2020
@razajafri
Code cleanup
26ebd79 
Addressed the following issues
NVIDIA#1285
NVIDIA#1286
NVIDIA#1287
NVIDIA#1288
NVIDIA#1289

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
razajafri added a commit to razajafri/spark-rapids that referenced this issue Dec 8, 2020
@razajafri
Code cleanup
bfa78af 
Addressed the following issues
NVIDIA#1285
NVIDIA#1286
NVIDIA#1287
NVIDIA#1288
NVIDIA#1289

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@sameerz sameerz added the feature request New feature or request label Dec 8, 2020
razajafri added a commit that referenced this issue Dec 9, 2020
@razajafri
ParquetCachedBatchSerializer code cleanup (#1311)
8f8c30e 
* Code cleanup

Addressed the following issues
#1285
#1286
#1287
#1288
#1289

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

* addressed review comments

* we still need to throw the exception

* more clean up

Co-authored-by: Raza Jafri <rjafri@nvidia.com>
@sameerz sameerz added task Work required that improves the product but is not user facing and removed feature request New feature or request labels Dec 16, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@razajafri
ParquetCachedBatchSerializer code cleanup (NVIDIA#1311)
e833b2d 
* Code cleanup

Addressed the following issues
NVIDIA#1285
NVIDIA#1286
NVIDIA#1287
NVIDIA#1288
NVIDIA#1289

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

* addressed review comments

* we still need to throw the exception

* more clean up

Co-authored-by: Raza Jafri <rjafri@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@razajafri
ParquetCachedBatchSerializer code cleanup (NVIDIA#1311)
ad01bfd 
* Code cleanup

Addressed the following issues
NVIDIA#1285
NVIDIA#1286
NVIDIA#1287
NVIDIA#1288
NVIDIA#1289

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

* addressed review comments

* we still need to throw the exception

* more clean up

Co-authored-by: Raza Jafri <rjafri@nvidia.com>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to e55f944124cc6cc2b847325fb448c2d9155ad188 (NV…
e2d49e8 
…IDIA#1288)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@razajafri razajafri

Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sameerz @razajafri