ParquetCachedBatchSerializer code cleanup #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razajafri
force-pushed
the
code-cleanup
branch
from
9ba5dff
to
26ebd79
Compare
Addressed the following issues NVIDIA#1285 NVIDIA#1286 NVIDIA#1287 NVIDIA#1288 NVIDIA#1289 Signed-off-by: Raza Jafri <rjafri@nvidia.com>
razajafri
force-pushed
the
code-cleanup
branch
from
26ebd79
to
bfa78af
Compare
|
build |
1 similar comment
|
build |
revans2
reviewed
Dec 8, 2020
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
|
build |
|
@revans2 have I addressed all your concerns? |
razajafri
commented
Dec 8, 2020
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
|
build |
|
@revans2 the code looks cleaner now. Thanks. Do you have anything else? |
|
build |
revans2
approved these changes
Dec 9, 2020
jlowe
approved these changes
Dec 9, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Code cleanup Addressed the following issues NVIDIA#1285 NVIDIA#1286 NVIDIA#1287 NVIDIA#1288 NVIDIA#1289 Signed-off-by: Raza Jafri <rjafri@nvidia.com> * addressed review comments * we still need to throw the exception * more clean up Co-authored-by: Raza Jafri <rjafri@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Code cleanup Addressed the following issues NVIDIA#1285 NVIDIA#1286 NVIDIA#1287 NVIDIA#1288 NVIDIA#1289 Signed-off-by: Raza Jafri <rjafri@nvidia.com> * addressed review comments * we still need to throw the exception * more clean up Co-authored-by: Raza Jafri <rjafri@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#1311) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the follow-on items opened as a result of #1265. I have made 0.4 the target branch.
#1285
#1286
#1287
#1288
#1289