Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools jar should include common jar rather then copy ThreadFactoryBuilder #5238

Closed
tgravescs opened this issue Apr 13, 2022 · 0 comments · Fixed by #5270
Closed

Tools jar should include common jar rather then copy ThreadFactoryBuilder #5238

tgravescs opened this issue Apr 13, 2022 · 0 comments · Fixed by #5270
Assignees
Labels
P0 Must have for release tools

Comments

@tgravescs
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
there was dependency issue with tools jar and common jar in #5233 We copied some code to deal with it for 22.04, but ideally we would have just kept the dependency on the common jar, only included the class we needed via the shade plugin, and generated the proper dependency reduced pom file.

note we need to update deploy scripts to use that dependency reduced pom file as well.

@tgravescs tgravescs added ? - Needs Triage Need team to review and classify P0 Must have for release tools labels Apr 13, 2022
@nartal1 nartal1 self-assigned this Apr 13, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Apr 19, 2022
@sameerz sameerz added this to the Apr 18 - Apr 29 milestone Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Must have for release tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants