Fix tools depending on the common jar #5235
Conversation
Signed-off-by: Chong Gao <res_life@163.com>
res-life
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
|
build |
|
Copied |
|
verified it works, +1 |
| @@ -0,0 +1,52 @@ | |||
| /* | |||
There was a problem hiding this comment.
May be we can change to use add-source to avoid copy it?
diff --git a/tools/pom.xml b/tools/pom.xml
index 1fb24656b..e5331324b 100644
--- a/tools/pom.xml
+++ b/tools/pom.xml
@@ -132,6 +132,24 @@
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>build-helper-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>add-source</id>
+ <phase>initialize</phase>
+ <goals>
+ <goal>add-source</goal>
+ </goals>
+ <configuration>
+ <sources>
+ <source>${project.basedir}/../common/src/main/scala/com/nvidia/spark/rapids/</source>
+ </sources>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
</plugins>
|
|
||
| // This is similar to Guava ThreadFactoryBuilder | ||
| // Avoid to use Guava as it is a messy dependency in practice. | ||
| // This is copied from the common module |
There was a problem hiding this comment.
We are already using the shade plugin to include the common module. So I see this more as a problem of not using a dependency-reduced pom rather than the need to copy code. For example, the pom probably also says it needs the scallop jar as a dependency despite the fact that we are using the shade plugin to include it. This PR removed the need for the common module but the config for the shade plugin still requests its inclusion.
Personally I'd rather see us fix the pom, using a dependency-reduced pom to publish rather than shade and still list shaded dependencies as it is doing today.
|
put up replacement PR #5239 to get this in quickly |
|
also filed followup to change to use reduced pom: #5238 |
|
closing since other pr merged |
Fixes #5233
Tools jar is a standalone jar, should not depend on common jar
Signed-off-by: Chong Gao res_life@163.com