Fix tools depending on the common jar #5239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
|
Note have followup #5238 to change to use reduced pom in 22.06 |
jlowe
approved these changes
Apr 13, 2022
pxLi
approved these changes
Apr 13, 2022
nartal1
added a commit
to nartal1/spark-rapids
that referenced
this pull request
Apr 14, 2022
This reverts commit cec1b7d.
nartal1
added a commit
that referenced
this pull request
Apr 20, 2022
* Revert "Fix tools depending on the common jar (#5239)" This reverts commit cec1b7d. * generate reduced pom Signed-off-by: Niranjan Artal <nartal@nvidia.com> * add minimizeJar to include classes Signed-off-by: Niranjan Artal <nartal@nvidia.com> * update spark-nightly-build.sh to to deploy dependency reduced pom Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5233
This is the same as https://github.com/NVIDIA/spark-rapids/pull/5235/files but removed the include of the common jar in the shade plugin.
Tools jar is a standalone jar, should not depend on common jar
Signed-off-by: Thomas Graves tgraves@nvidia.com