Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Range window-functions with non-timestamp order-by expressions not falling back to CPU #925

Closed
tgravescs opened this issue Oct 9, 2020 · 1 comment · Fixed by #931
Assignees
Labels
bug Something isn't working P0 Must have for release

Comments

@tgravescs
Copy link
Collaborator

Describe the bug
We have a user trying to do an orderby on a non-timestamp column over a range and its throwing an exception at the CUDF level:

Caused by: ai.rapids.cudf.CudfException: cuDF failure at: /ansible-managed/jenkins-slave/slave2/workspace/spark/cudf_release/cpp/src/rolling/rolling.cu:1157: Unsupported data-type for timestamp-based rolling window operation!
at ai.rapids.cudf.Table.timeRangeRollingWindowAggregate(Native Method)
at ai.rapids.cudf.Table.access$2800(Table.java:35)
at ai.rapids.cudf.Table$AggregateOperation.aggregateWindowsOverTimeRanges(Table.java:1906)
at com.nvidia.spark.rapids.GpuWindowExpression.evaluateRangeBasedWindowExpression(GpuWindowExpression.scala:211)
at com.nvidia.spark.rapids.GpuWindowExpression.columnarEval(GpuWindowExpression.scala:119)

This should have ideally fell back to the CPU.

@tgravescs tgravescs added bug Something isn't working ? - Needs Triage Need team to review and classify P0 Must have for release labels Oct 9, 2020
@tgravescs
Copy link
Collaborator Author

this was partially fixed by the lead/lag feature. I found one issue with the handling of nullable columns so will fix that under this issue

@tgravescs tgravescs added this to the Oct 12 - Oct 23 milestone Oct 13, 2020
@tgravescs tgravescs self-assigned this Oct 13, 2020
@tgravescs tgravescs removed the ? - Needs Triage Need team to review and classify label Oct 13, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
[auto-merge] bot-auto-merge-branch-23.02 to branch-23.04 [skip ci] [bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Must have for release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant